[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen/rpi4: implement watchdog-based reset
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 9 Oct 2020 16:52:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iVJrITW8CwGkDrhswFYdOGz5HdCluBOgNTFnJnmzA8g=; b=AToywdoJzy1AXsCuYXI1gBqugo1+oJ1VevHIf43/MPUf4nBcEWYqsJfvqeWCsw0vi4/1DuGeDhL2ckT7Ujxou1WU1qcqUkvSKohkHvY+oB7iwCRidXA2FTUJJyIpDFyZCUwQetYEvsZwJW9isXNJDThQzqc9Ox2kNlC/0eZXifCwBhHstFOziCQcByG1xuQZzC1j3x0yHmWx/Xm3wSCJeQjPBBCKTNd4P3llNPxILLyqqZt5O7VqqpdGnVdOeEiKcgG/Siq2K9o/ZnevVXjrunwbyaaXHzJkEX58P7gq+r7lU4C3rFvIbIEUKnob0aPDvUbBAZ0HBSPnbltHGjlC2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RXcBw/6WiTJRGigSbDt37ZmGZi+WUo4Gcy/I/zWh40M4QpludOnlj8wndKPpxyA8Y1X4BTZF+agLVtXHIQjDDVqmRDmFoowcOzck52aDqyNnMx+1SdAId7P+/IGe2oE68l6p4GjBQS7I4EAhxvxSN/8Z8zZZIhq+KKh+HnwvFVvsSHDzPxW/Hf2Aczif2CIyGgi8Oa/j7wIqO+1J+Yl9LaNInbBuJOxxY/+nNapWdLrLQxpyHhESltX+Z/SNKMvxIftnnRHbUEkm7NYVPrugN/WyDm5RpY/bhlxtjE60iqN1Mirve4Da9JJ9R4TtphhWbMETKRSQGv81w2oMTB/LnQ==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, "roman@xxxxxxxxxx" <roman@xxxxxxxxxx>
- Delivery-date: Fri, 09 Oct 2020 16:53:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWnPqc7v70BAMN4EaAQA/1huLhsamNV4yAgACv0gCAAN+3gIAAkuUAgAAFQwA=
- Thread-topic: [PATCH v3] xen/rpi4: implement watchdog-based reset
Hi Stefano,
> On 9 Oct 2020, at 17:33, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> On Fri, 9 Oct 2020, Bertrand Marquis wrote:
>>> On 8 Oct 2020, at 19:27, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>>
>>> On Thu, 8 Oct 2020, Bertrand Marquis wrote:
>>>>> On 7 Oct 2020, at 23:38, Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>>> wrote:
>>>>>
>>>>> The preferred method to reboot RPi4 is PSCI. If it is not available,
>>>>> touching the watchdog is required to be able to reboot the board.
>>>>>
>>>>> The implementation is based on
>>>>> drivers/watchdog/bcm2835_wdt.c:__bcm2835_restart in Linux v5.9-rc7.
>>>>>
>>>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>>>>> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>>>>
>>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>>>
>>>> Maybe a printk if reset was not successful ?
>>>
>>> That not quite platform specific but we could add a printk to
>>> xen/arch/arm/shutdown.c:machine_restart if we are still alive after
>>> 100ms.
>>
>> Even nicer :-)
>> Definitely usefull to see something if for one reason reset/restart did
>> not succeed for whatever reason.
>>
>>>
>>> I'll commit this patch as is and maybe send another one for
>>> machine_restart.
>>
>> Please tell me if you want me to handle that one (at the end I did request
>> that so not really fare to ask you to do it:-) ).
>
> Since you are volunteering, yes please :-)
Fare enough
I will add this to my small fixes list :-)
Cheers
Bertrand
|
