[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Fri, 30 Oct 2020 09:45:44 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+XAE+Tgudorm68WDbKIYoFOWYX6Cb5xc02saLZogKQ=; b=Wey6TZjhFUuxK55BBcDA8/ntkZUlCL3Iwt7lFRuYfYceODWgjqa7PGrehpr1ITFKo92Y+nu3ivnJJk6UaFQvWeA8FKYBTwwDQTuRWmAyftPC9tpp0qZNu/HWtTroQbxP2AyeUQbhQnbqU4HAlv+WbHsc76OgUpAfTOeZ2ZUBvx8p0Vdgf9NdL7aqtrXOSzsaIqB+cAFJNWJ1yekOOKuFyFBVVs/VatTnIxDOtsdExSS2jJlkQOUvzSDtUYuUpgcglN+xl2S1qWrQPbL27R9q5TM1HuI+QzwrWoQk9vrlYD0924oEf+HC4Stnm/lNBIlU34ZTCQn0yuS/EdjLXtVOXQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nK2BnITnKhWaFyE8dumR2qt+EmGj0JMEm7w8HQlRSMM497ETeh6p07Fs93Mpo1r5gRlws3Vd78cz1HDs6qnQyJKtKRi3HUVcRH9kXfl3oIp1PGvmwZHYC6AuXOBqKCl0Cwy2Zl8tSlxA3dcK9TOkKeHAhVNd5Lv4vj7KlwwnveFBqEyUBSpX65IGc5+cCfkojAFyW6fUdFc3qb2IqwieqWILcLKusq3ip4np8pnq4N/GZpRwzqxWC1zQPhmI3TxKKsa/xa1m1pZlxhky6ZQlHUNXdDEksqOnt4kxiqRxK3vg6vp/xlfDs+KLDQVlZQPCSjqwk+y3tASxOKVSk8uiEA==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 30 Oct 2020 09:45:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-topic: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

Hello Julien,

> On 30 Oct 2020, at 9:21 am, Julien Grall <julien@xxxxxxx> wrote:
> Hi,
> On 30/10/2020 08:46, Rahul Singh wrote:
>> Ok Yes when I ported the driver I port the command queue operation from the 
>> previous commit where atomic operations is not used and rest all the code is 
>> from the latest code. I will again make sure that any bug that is fixed in 
>> Linux should be fixed in XEN also.
> I would like to seek some clarifications on the code because there seem to be 
> conflicting information provided in this thread.
> The patch (the baseline commit is provided) and the discussion with Bertrand 
> suggests that you took a snapshot of the code last year and adapted for Xen.
> However, here you suggest that you took an hybrid approach where part of the 
> code is based from last year and other part is based from the latest code (I 
> assume v5.9).
> So can you please clarify?
> Cheers,

Approach I took is to first merge the code  from the commit ( Jul 2, 2019 
7c288a5b27934281d9ea8b5807bc727268b7001a ) the snapshot before atomic operation 
is used in SMMUv3 code for command queue operations.

After that I fixed  the other code( not related to command queue operations.)  
from the latest code so that no bug is introduced in XEN because of using the 
last year commit.

> -- 
> Julien Grall




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.