[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap


On 30/10/2020 18:28, Stefano Stabellini wrote:
On Fri, 30 Oct 2020, Julien Grall wrote:
Hi Stefano,

On 24/10/2020 01:16, Stefano Stabellini wrote:
On Fri, 23 Oct 2020, Julien Grall wrote:
   bool __acpi_unmap_table(const void *ptr, unsigned long size)
       vaddr_t vaddr = (vaddr_t)ptr;
+    unsigned int idx;
+    /* We are only handling fixmap address in the arch code */
+    if ( (vaddr < FIXMAP_ADDR(FIXMAP_ACPI_BEGIN)) ||
+         (vaddr >= FIXMAP_ADDR(FIXMAP_ACPI_END)) )

Is it missing "+ PAGE_SIZE"?

     if ( (vaddr < FIXMAP_ADDR(FIXMAP_ACPI_BEGIN)) ||
          (vaddr >= FIXMAP_ADDR(FIXMAP_ACPI_END) + PAGE_SIZE) )

Yes it should be + PAGE_SIZE. Do you mind if I fix it on commit?

No, I don't mind. Go ahead.

I technically don't have a ack for this patch. Can I consider this as a Acked-by? :)


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.