[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libs/light: pass some infos to qemu

  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 18 Jan 2021 10:07:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WmOAjiuRo6BbvLSI1vLEeRt3o6TXNvDVW6l6Ymi6Qw=; b=YzMSj+iVmJMw6RGJE0G4SYSV9U/G1rf1kHaZL1lZ6OQe2SRVIJj1jCL9O1NaOJsZRxFNiINsYVrPAgh7eaPMaJRiIfiJHNUFG8o6+E27U/ok8Rk1waOm+aJ+VJNmWeVg9C7IAVaqwLPkDzRNho8vOQhmpgqnfhUpNpGN/kt+zchEGZDl+6mWAdO/MDJEj9MQCFEDJtaIuxE6MqREkaqlJeg/4ahj5wF/YU9Axwmeu0ZDHtBR+XDuCT/fzXCwMk23N9nsghQcw/dMHIjVUk95zpK4HAkw6eikuHwtaPApk+s53k6lMMEy7LMVS5ce2Ny+ktXRKWhKs9PgFVNmJRROXQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGCboW7OyCMhf8bVWgbigoOtCvm/gPiQUDMibXCc3Zww+UmLDCS9uOksSEFBVUb+ULvvhAM4VVNcVtbL0SVzPPfaWh5VCrPSOkRdTtZZkN7iIsM3ASVliW1NNWXeV7Cxz2CaHj8F2O/sy/5TjWlOy8C2Ezeh16tp+SaDlsnuLpDVnzUHdt14Y2RXOboRd40Nc4B0ps6DxCWXlQIbX5JoOjp1NWZsFpgBQdmsjFX3w14SSWntRbaXpiF1Zf26HVg2Whto/kvMtvaSf4iWHFuCgzB9U3vC7fqn9OZ7WUoKesrlPicGMTSUXDGro5fSgeKxgwuvs1VSIpZl95uPyRQaWQ==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Mon, 18 Jan 2021 09:07:39 +0000
  • Ironport-sdr: sX27heeV+rQIuwATNrfgnByHsl2q5VXVCXMouYN5UabeO/i+aGMHqtqlvfGsRXqbzthQQORFPc ldotuo88pKjSOP9e0/AijEHzo3PoEJi5RWPgeCbZDy2+7JemZYILCnguALhGkPl1qCePbfjK+E 7N2neVQ9K2WoywXkxpvtWDEZxcIu+0rE7upmHlzcqmPO8dDJF9KqHg7B9OU0Ivq3wIfhvi3Xa9 YseufnGNdEOpd/sfDnXE8bi9hmOs2bADUcGnuRj6z31NYZqV+9/r3K2UM+LitIM+zGCahBzwI0 fMw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote:
> On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote:
> > I also wonder why NetBSD needs to add the tap interface to the bridge
> > in the QEMU script instead of doing it from the hotplug script called
> > by libxl, like Linux and FreeBSD do.
> the tap interface is created by qemu itself, its name is not known outside
> of qemu. Also, is there guarantee that qemu has created the tap before
> the hotplug script is called ?

Yes, the toolstack will wait for QEMU to be initialized at which point
the tap interface has been created.

I think I remember now why this didn't work on NetBSD. We ask QEMU to
create the tap interface with a specific name (using the vifname=
parameter), but NetBSD doesn't have the ioctl to rename network
interfaces implemented, and thus cannot rename the interface from tapX
to vifX.Y-emu, and hence you need to use the QEMU script from QEMU
itself because it's the only entity that knows the name of the tap
interface created.

If you agree, can you add something along the lines to the commit
message? So that we remember why NetBSD needs to use the QEMU scripts.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.