[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

  • To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 9 Sep 2021 13:53:56 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TgsW9dSRnjtKa60RLy4P2pvYkjr9xFazVfaG+r2YUiM=; b=emaD0BFYl1rP6DYAZ7i+ZLf74NFpoq4+x0c0Qwlv+N4/yJf7zf/+TSFDEmCuj9SMdswTrebh0ygWyfmolJqXGpkTyKYZhDRFx2ZXDwCCTght+Ec0onVxUCy9TNwtvbX+QJMlVuxA4ZBlGCyRY/BFsLzwlECfaf3IkHddFrmh3ng6X2UcuE2oj1gRc+X2lBMeLlAaDIbFTcE9nJ4872b+5XQ3krwvzH1ZAjM2S7a0asIV21CB7y+BU1cotxXJLSHCtN2HWtoV7OmpEgpGughEjZ+dDTUS6CMK5KaXgLQ7xHu2RiGnz7vajv3kBUg+nrfUFAHyYIMyNZDQhqMwfm2u1g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9jtM8tAumPlVyMT06PX7MInqmCz0zjNbFoTUqvlUGz1fC+uMNXli1/jZXyyfRSXDd1p6DQ6Ba3kNNu0B8G1gxbtd244cLODFRhRN4gqRzxrb2upxyppnr7vSuGg7ZpU9Ja62VxhmcOs/aBhBXJ9kXgPLsX5Y0S6Rlrmmun/kO4QRnvPtO+og1cNky6TH9ZNaN1Zi0g02dL0YxW0b7fsAQ6nBmDXeZ2RkYo9+p0OaQ5Ch4zmft98fqmUob6jK6w5HBk9wP4mRFaibGgsylSeTTbCOQ5BU79X6YF1mUEBzRPIG5bxHUfeu7siEmHTFBRx20RY8qrPGpekczZvquNZfg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 09 Sep 2021 11:54:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 09.09.2021 13:48, Oleksandr Andrushchenko wrote:
> On 09.09.21 12:21, Jan Beulich wrote:
>> For the bit in question, where the goal appears to be to have hardware
>> hold the OR of guest and host values, an approach similar to that used
>> for some of the MSI / MSI-X bits might be chosen: Maintain guest and
>> host bits in software, and update hardware (at least) when the
>> effective resulting value changes. A complicating fact here is, though,
>> that unlike for the MSI / MSI-X bits here Dom0 (pciback or its PCI
>> susbstem) may also have a view on what the setting ought to be.
> The bigger question here is what can we take as the reference for INTx
> bit, e.g. if Dom0 didn't enable/configured the device being passed through
> than its COMMAND register may still be in after reset state and IMO there is
> no guarantee it has the values we can say are "as host wants them"

In the absence of Dom0 controlling the device, I think we ought to take
Xen's view as the "host" one. Which will want the bit set at least as
long as either MSI or MSI-X is enabled for the device.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.