[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Thu, 9 Sep 2021 12:42:27 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dKHyWW00OiPqWRQnC1OyVPFE5xoD65yUS79ETpBcvdU=; b=YduDzhyaYx1IB+LPZBpRlK744qawuwpxhITlnWsbfRGftcK2tt/zXcV65ewoKPZN/80xGau8QTQmIZsZlIMzAz4kSZkFqcO+Ou38mPKAK6YzP0rIOYT/Eet3JcleFk1r1j7l9XdkHRFbu6IJuCdOXG4vrjnAFvNOfewsNzGVpZ93+GUAlwLEuE3MQfjk1o31fN/z4f5HOsOfaPGJyspYh19WJnaz6j0PJ/4Y76jU7yMkA/QaIv7WIvQ5w9eC+0yFQtB5XeKlogdOtyOKGyLpInz3WmfSoem1fcmKqBooeL8OU2z/gKMGqMMQBpu7oVxj73FyPVtZmUtpHakz8+KJIg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mG7Bs+fz4tSWEDsPPq/ePr8a4LrZaR+bgOF45LsaUaBlDzNL7A20rw1v9YZZVkDznooTg9AjMz3QlY8XOfenRG7qeQ7y4gfJoGRLNx/IKIdQ0a3CB7ulEdHdOvTDCWAfw9m7+pTDCUq4tqmpvONE3V6PCuWR1YuTMcyaPs5qNTQHx9B6e7WsAMTyKUsJe9FxMZSRUVjuPrpri1/MJnLkNwATs/T+aN/vOn2NDMynVbJgZiaUHCav1y6oaFB56mlJ8xfeOcqQ0e7/J2BJ7RshQi/mDpc97vadm94EYfWUrKncoBMekw0Up8AgOTNq2b6l9+o7P6Swod64DCE4vHXXDg==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 09 Sep 2021 12:42:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-topic: [PATCH 8/9] vpci/header: Reset the command register when adding devices

On 09.09.21 14:53, Jan Beulich wrote:
> On 09.09.2021 13:48, Oleksandr Andrushchenko wrote:
>> On 09.09.21 12:21, Jan Beulich wrote:
>>> For the bit in question, where the goal appears to be to have hardware
>>> hold the OR of guest and host values, an approach similar to that used
>>> for some of the MSI / MSI-X bits might be chosen: Maintain guest and
>>> host bits in software, and update hardware (at least) when the
>>> effective resulting value changes. A complicating fact here is, though,
>>> that unlike for the MSI / MSI-X bits here Dom0 (pciback or its PCI
>>> susbstem) may also have a view on what the setting ought to be.
>> The bigger question here is what can we take as the reference for INTx
>> bit, e.g. if Dom0 didn't enable/configured the device being passed through
>> than its COMMAND register may still be in after reset state and IMO there is
>> no guarantee it has the values we can say are "as host wants them"
> In the absence of Dom0 controlling the device, I think we ought to take
> Xen's view as the "host" one.
>   Which will want the bit set at least as
> long as either MSI or MSI-X is enabled for the device.
But what is the INTx relation to MSI/MSI-X here?
> Jan
Thank you,




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.