[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] domctl: hold domctl lock while domain is destroyed
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 20 Sep 2021 10:19:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XHapG8vGOL6k8MmAWvtdgtXa/ewF3aDJIfEjIaAOB6k=; b=DXwpXIJ2Aw6cVHz0zosNQG5ky/iJ93fmFJFNCLUmQdhIKVu7Sluvvqq3Vy4zr8biXq9VC7q4Dicv/UYzQ8fxea9CgF2Hr2MdPY9f4OMsOC63S8Ml3vNjTcDQUrkEGGQIjWOlWqk2Mmjfby1uwrFV0ZGbovVFoZre/GlDgHsfdN304wa/O+TFvEzRp8IqtpFwqiilLkaV19+tmML+faydhiZx78rSMQcj9Eyd0maRC6HQGDf/+MSUKCXe10GLHUw7nX8jmzx48WTp4FsqnoUrneCgdSUKLe/Xcv8xQemTOT7tWUwUkFjwdEluWt6PSMBXicSRgwMcxEb2JzAC01Y70w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEtieiN88TuWYQhzutF/GZiVq7N+zHXmC1Iz8ofaA9mipkaAUUZ3NGGU6vTj8VCSaLV+lyPgkapZ+KmCWWLfyvLX0LSD9DksgzIYtjjM6LYo68IeByzyjBRu6cG6pcqGHH/NuTutlZV67eir1vho6Iykmr2BqB3gHDaEmRaN/UABHd4FXU3lVeSPJTpnvYisOAXcM08KP7OoDtyv6yX4xar7VAf1ChYOvEFIUGyou+fVEiQ7ouIY7GhlQpHCAsJnlLB5A4lcncYmlDQBlkGpElLaxEfZKjLMvBWGKJdq7o54J1rFJs0gH/8ooIsCUEYqk1ZE8Ueagha1ssiHKGXXJQ==
- Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Dmitry Isaikin <isaikin-dmitry@xxxxxxxxx>, rjstone@xxxxxxxxxxxx, raphning@xxxxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 20 Sep 2021 08:19:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.09.2021 18:01, Julien Grall wrote:
> I will quote what Hongyan wrote back on the first report:
>
> "
> The best solution is to make the heap scalable instead of a global
> lock, but that is not going to be trivial.
>
> Of course, another solution is to keep the domctl lock dropped in
> domain_kill() but have another domain_kill lock so that competing
> domain_kill()s will try to take that lock and back off with hypercall
> continuation. But this is kind of hacky (we introduce a lock to reduce
> spinlock contention elsewhere), which is probably not a solution but a
> workaround.
> "
Interesting. Is contention on the heap lock merely suspected or
was that lock proven to be the problem one?
Jan
|