Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers

[Julien Grall <julien@xxxxxxx>]

Hi,

On 28/10/2021 16:27, Oleksandr Andrushchenko wrote:
> bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE...
> So, I would stay with simpler
>
>       if ( bridge )
>          {
>              sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>              sbdf.seg = bridge->segment;
>          }
>          else
>              sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
I am fine with that so long this is part of an helper (maybe 
vpci_sbdf_from_addr()) rather than duplicated.
Cheers,

--
Julien Grall