[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] xz: add fall-through comments to a switch statement



Hi Jan,

On 26/11/2021 09:12, Jan Beulich wrote:
Anyway, I think it would save time for everyone (you had to manually
delete signed-off-by after all) if you just copy the commit (including
all the signed-off-by) message as-is.

I don't think I see why you found it necessary to verify the S-o-b set.

This is a list of difference with the Linux commit that was unexplained to me.


Also note that, for things to be useful in our tree, I may also edit
commit messages in mechanical ways (e.g. to change file or function
names). I don't think you can expect a 1:1 match in any event.

I am fully aware that I can't expect a 1:1 match. However, if I see a difference, then I need to be able to explain it.

For this case, you provided some sort of an explanation but so far, I am still waiting for a link to confirm that the signed-off-by match the one on the ML.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.