[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
- To: Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 20 Apr 2022 14:00:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/v1WE61xkur4osDmCIiuy0rcZqs2HZfVCItorOm5zQ=; b=TgK+7s2yrx/Iw6J4IklehKaOP1ly8yxHh4ct6tPO0mNdcULaakmVwXpdwlHbV4t5C687qT26I3lk9NgI3ymtdpyfU7Mp3Da2YeNw0z+fXs/eAmQg8T0tCQ0B8OeaRBJigMYUxSfz30hWEJMJIQqCEfd73LKJZHF40oQkxyRRJrTERBmjbwmaluIAkOl2wL+6fp3aEhpzKzVxx1d7BKoyZFGL6yCb9NKuwWFhYuOM0ECjvXbUo9kFAPqZCW81Lbyu8PXfatJeNNVbHOBHvsd8hDT3CmgV1ZIAG0QH6yWQTDAG3kNiACPrF5o0gJN2fRgXMP0eIpwnVN1chdnQQd8EjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GK57qlGm2vsUBFaCW58Y75RqpKG5YfENijiafO43wWg3vcoiuSB+68GE5JxQaM4Na0HC8boJpXmcURkM8xJDwFTNAtF3RjAy6Xw1OFXwbf/kR5Tq8565GAMtbPVQADSMYgkiApn8ma2pKyXyZrGvlEeqHtYm/vJWV1IkJM3oSb+DlWSxV0DW2m0aZe88J5qt4bzzuzcv9F4ciJsXUJ185SUd5IX5SMJTnlhnOg+P1KJfPN6GMSfCQLpwd7/B3mZGF/o1OmUFOcyAXzdGCbUEYNogBDFqDfLAnYrcpmSiEb1I21mKAZEkvf6ED4+atMYvLP8Jc6yJ+dAVMbeKeIJdEQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 14:00:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYTbfiNTg+IXy/G0GwaoqGDOL0yazq2Y4AgAEwcQCAAAivgIAA2MwAgACFroCAAAHtgIALb2GA
- Thread-topic: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
> On 13 Apr 2022, at 08:22, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 13.04.2022 09:15, Luca Fancellu wrote:
>>
>>>>
>>>> No, I'm not suggesting a new menu. I was merely wondering whether the
>>>> Kconfig contents wouldn't location-wise better match where the
>>>> respective source file lives.
>>>
>>> It could be in xen/common/sched/Kconfig at the beginning of the file
>>> before creating the new "Schedulers" menu, e.g.:
>>>
>>> diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
>>> index 3d9f9214b8..f6545f4e9b 100644
>>> --- a/xen/common/sched/Kconfig
>>> +++ b/xen/common/sched/Kconfig
>>> @@ -1,3 +1,10 @@
>>> +config BOOT_TIME_CPUPOOLS
>>> + bool "Create cpupools at boot time"
>>> + depends on HAS_DEVICE_TREE
>>> + help
>>> + Creates cpupools during boot time and assigns cpus to them. Cpupools
>>> + options can be specified in the device tree.
>>> +
>>> menu "Schedulers"
>>> visible if EXPERT
>>>
>>>
>>> I think it is fine either way, so:
>>>
>>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>
>> Thank you Stefano,
>>
>> Jan for you is it ok at the beginning like Stefano said?
>
> Personally I'd prefer it at the end (still outside the menu), but
> really the scheduler maintainers are going to have the final say.
Hi cpupools maintainer,
I’m going to address this final comment and re-push the serie, in order
to avoid further noise, would you mind to give me a feedback on that?
What is your preference for the Kconfig parameter placement, beginning
of the file or end?
Thank you.
Cheers,
Luca
>
> Jan
|
