Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

[Juergen Gross <jgross@xxxxxxxx>]

On 20.04.22 16:00, Luca Fancellu wrote:
> > On 13 Apr 2022, at 08:22, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >
> > On 13.04.2022 09:15, Luca Fancellu wrote:
> > > > > No, I'm not suggesting a new menu. I was merely wondering whether the
> > > > > Kconfig contents wouldn't location-wise better match where the
> > > > > respective source file lives.
> > > > It could be in xen/common/sched/Kconfig at the beginning of the file
> > > > before creating the new "Schedulers" menu, e.g.:
> > > >
> > > > diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
> > > > index 3d9f9214b8..f6545f4e9b 100644
> > > > --- a/xen/common/sched/Kconfig
> > > > +++ b/xen/common/sched/Kconfig
> > > > @@ -1,3 +1,10 @@
> > > > +config BOOT_TIME_CPUPOOLS
> > > > + bool "Create cpupools at boot time"
> > > > + depends on HAS_DEVICE_TREE
> > > > + help
> > > > + Creates cpupools during boot time and assigns cpus to them. Cpupools
> > > > + options can be specified in the device tree.
> > > > +
> > > > menu "Schedulers"
> > > >         visible if EXPERT
> > > >
> > > >
> > > > I think it is fine either way, so:
> > > >
> > > > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > Thank you Stefano,
> > >
> > > Jan for you is it ok at the beginning like Stefano said?
> > Personally I'd prefer it at the end (still outside the menu), but
> > really the scheduler maintainers are going to have the final say.
> Hi cpupools maintainer,
>
> I’m going to address this final comment and re-push the serie, in order
> to avoid further noise, would you mind to give me a feedback on that?
>
> What is your preference for the Kconfig parameter placement, beginning
> of the file or end?
I'd put it at the end, as the scheduler selection is generally of more
interest IMHO.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature