[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 12 Jul 2022 18:06:25 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZP6fa15XvoEgGF6rY28POJi8BYMre1S+CRD4KJ5VnmQ=; b=CXT56dJ6UtWqa1cyuYzOu/qYPilD3ZdoNjAZ+HGJNaK8pfARB+shZnJyHzLGK0ED34H6qC79LaksjABBlKIV8YOiwql41fMrAZE2e5qrFxNMH5unONNPaxe/oco12WxG2s7KC94oYKnuwmN1XczZhwEejXw+iJoG/PO1Al3xn53t+3k3HrrTmGuFQKfGDHIGyjDF4ECsyvW8k4epV/vr52KuweFf1jztfvKSjK/h+4FkW/fkdk09cPfqVeqxlaz8ub1AtAMNC2JCxoDFUQVggJNsUg12uBJ4dFo/ef7gmnq9EFMybhn4Uxkrua6K5XozNFk/A1nN2SRAFTQ/IH09UQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0MN7PLS2AmEUQyyfCfJ8K1kq43lsXZXzjP51VHcKZXe1OqdYkZy2vxAuwniwXCHj4U01RTfAh1P+HoLdhTf9JVnTA/2yWk3bq7FCupLZyu4nNDX62irPp7IzchuTR84w50OsjAq6ybAif6BR7Ri2EaGSaNFnA0LSiTMYkZA05cowEmGI/xJjAXdkmpGXH1YmPaT5vLE8vzim4fEhMasiThkkaUItPakIbTUxPiGmdLy8N+Z8Nlvskvb+p8mxnSBVdRYnXksIGpXN4JR9CTXq/uSoCkWpgFLMlIKBYMbP0J9BLymnlZzc/qJpaC7JMQuXoCViEaaJ6Q9fapxByKsRw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 12 Jul 2022 16:06:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote:
> From: Connor Davis <davisc@xxxxxxxxxxxx>
> 
> [Connor]
> Xue is a cross-platform USB 3 debugger that drives the Debug
> Capability (DbC) of xHCI-compliant host controllers. This patch
> implements the operations needed for xue to initialize the host
> controller's DbC and communicate with it. It also implements a struct
> uart_driver that uses xue as a backend. Note that only target -> host
> communication is supported for now. To use Xue as a console, add
> 'console=dbgp dbgp=xue' to the command line.
> 
> [Marek]
> The Xue driver is taken from https://github.com/connojd/xue and heavily
> refactored to fit into Xen code base. Major changes include:
> - drop support for non-Xen systems
> - drop xue_ops abstraction
> - use Xen's native helper functions for PCI access
> - move all the code to xue.c, drop "inline"
> - build for x86 only
> - annotate functions with cf_check
> - adjust for Xen's code style
> 
> At this stage, only the first xHCI is considered. Later patch adds
> support for choosing specific one.
> The driver is initiallized before memory allocator works, so all the
> transfer buffers (about 2MB of them) are allocated statically and will
> use memory even if XUE console is not selected. The driver can be
> disabled build time to reclaim this memory.
> 
> Signed-off-by: Connor Davis <davisc@xxxxxxxxxxxx>

Btw - iirc this email address has already been bouncing for me when
replying to v1 patches. Interestingly enough you did Cc the cover
letter to Connor Davis <connojdavis@xxxxxxxxx> (which I'm using in
replacement for the other address in this reply). And I can only
assume that the address did bounce for you as well when sending
both v1 and v2 ...

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.