[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Jul 2022 08:05:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=24sQSeTVr8k/uNw9hI04MeMtAN4nyVGXxJrihRxWGkk=; b=Acv6/L4VA/DF3ihTpM6XDv7VIzPnHUmbrYgbIHdpXdOe99p77WuGA/Sd/c4zwVcArgoytDI+Smx8xak1vJRguYaYTjbRH805A5LDVxTWEtMV/4e7o7Hd/o/d6JMbWv1Y8k4k6vcICLTmszEmll6lYFYXLdEVnQkYa22VaIdN4jiBX7BYqFflybMMxaTRaVVkQSDZ73SBgKeTe1+1BzUcxTMWqKl33m8HKk5jn1MizRTHseNoaA+xQ2/Fk+hQsoPWDt0oh1mwpG2rzzynl9t3sU+KWXPAVClISxXT8882OS54kz8xC7zsTgElE2VQhu7TiCuD/tRcDZQUJAYPbvsXCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYAIjuyLuEejay4mhMFDu3jYQ58gAtC0Qj7v4WYdclfli9YclGHNzNkKQeAB3TfNRLBHQrfR77Xbl99gKWsjrCifGzdmSz0rbvwYposownHMTOgw9B9O54CR+XfBvzB4jC66QlP4nrF9+GD/HdlSEkqHIWY8RK1mYBJoz+hqcXmO81s5N6Mp+DGNw4t5AYKHhXwtRGM53OpLN/u5RW+/Z3sdvKL/qwJwXvVGheHo4DJUArz+lhS2/c5Dkohy3Tt4tGxTCRphuUNpOHG5o/z4pbGEJPBuOmHfGJfhvpRD1VMMKyPcq4gBSP47VW8yhF2sKZ0UfQMDZlqYDhSUBkHJ4g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Connor Davis <connojdavis@xxxxxxxxx>
- Delivery-date: Thu, 14 Jul 2022 06:05:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote:
> +struct xue {
> + struct xue_dbc_reg *dbc_reg;
> + struct xue_dbc_ctx *dbc_ctx;
> + struct xue_erst_segment *dbc_erst;
> + struct xue_trb_ring dbc_ering;
> + struct xue_trb_ring dbc_oring;
> + struct xue_trb_ring dbc_iring;
> + struct xue_work_ring dbc_owork;
> + char *dbc_str;
> +
> + pci_sbdf_t sbdf;
> + uint64_t xhc_mmio_phys;
> + uint64_t xhc_mmio_size;
> + uint64_t xhc_dbc_offset;
One more observation: None of these four field look to be needed.
They're all used only in a single function, so could be local
variables there (and xhc_dbc_offset is only ever written, so
could be dropped altogether).
Jan
|
