[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Jul 2022 12:58:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bibu7jyJrS/qbbXSfecX2SbhNuCbugRY9QRrHx+y2m8=; b=cWDyEq7QeuqoCKJqXTshmq4w+CCvUsAEf2jgePe2jV2XlQGNZLl3jaDcgOIxb81N4vRoIjJVcbEICK4TfFApGuAWsfcLqB3Wiftuq/IURQXHAuVwhmlg0jdAkwjr0guT2vGBlY+OEr/kMSmkgse4lFkLV824kJegYjV0WHiZ6a0CufrZatQoud6mVRnzTIktUyU3O4bMrtKi/ZVnjOQwuQhi5sEHzvkgpxAd+aYJU+ZiA4yQo1KcoXIqZdWHeIMj2SVykNfO/F6pkfVK/b988SeZGCVcHX/VefK2a5APq1x66+P3nIpJ9gZ3XgmitRHUX9IVNLTKkLN1CNY/frDTTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZqcYvpiRaXgY1bNUR/e5Gmv0re08+59jd7RbExT3SOo/6Qy/wGGkuWDcAOG33Evfqe89+bWZqpV9VZ+5Ou4a+Dxi3qv/CmNlicbe1x2hkpZSmXE5txUYTXcuYlOhippl+hZGosUZQakZ0CblduSpSJUTXlzRxVrvriCJRspWGlSrmBI6G9nmnKCVI9igphNVatH54ttECNxyV/XdJwI23IV7/eKam+ipf1+bGRmJCjAL7H/E1p9AjqMQ4+18Y9uQS4tLf3T1hGMpx/D+QP55UlA4NG+R5ROYZjSxEGbRLpOvB02p0s91wm2pUWHaWkX4t3jsE+ODCZ4roptyKkyJw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Jul 2022 10:58:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.07.2022 12:49, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年7月14日 18:37
>> status
>>>>
>>>> Well, this makes the table complete, but it doesn't explain how you
>> mean
>>>> to fold the settings of the two command line options into one variable.
>>>>
>>>
>>> No matter how many separate "numa=" parameters have been parsed from
>>> Command line, the values of these original variables are determined
>>> after parsing the command line. So the determined status can be mapped
>>> to the new one variable from above table.
>>
>> Hmm, I was partly wrong - the initial values of both variables are
>> indeed set from just the single "numa=" parsing. But later on they
>> "evolve" independently, and multiple "numa=" on the command line
>> can also have "interesting" effects. I'm afraid I still can't
>
> Can you provide some examples? This way I can better understand your
> concerns.
Take bad_srat(): you convert "acpi_numa = -1" to setting numa_no_acpi.
Yet imo (matching the present model) numa_off shouldn't be affected.
While your change is fine in practice for (current) x86, it is wrong
in the abstract model (which is relevant when making things common).
Jan
|
