[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen: sched: dom0_vcpus_pin should only affect dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Tue, 2 Aug 2022 16:08:56 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xDjXMzK7YB6oJPeFBRAOczX/sA16v7PRIDTy+9rNuBk=; b=ZvvzAtmVuE4EMFGKLPjLlbM7vaBeXsVgEyq+AY0dOL8N3a17NXCdsFOR31eHrK4S68No0mBITM7Tg6xmzna5+B7aZWELXG15vCy3QDt+Mk/JadCgDC+YcHN1Q49gBwI3A9w+eS6AiKLVAEDkOI8Uadc5p+io/nx4Tx+pBCS8hNFaCDiz3fujSaHIderJFPRL36jn0FuEFOSySd3peTo1xwQoY+NRwih+/pA24W57cHUNQUfVedAZwhuFmkINnmgmduaq9DrI6/d2oZC7NZj5E8qfqimioqhzghJFMbXBk9vLreGdodYmuga7oqLSkDej2hee3XIqbHFH+4bDAYJfBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JrTUVIAJrDvdEQPkKysS7YByXqnn3TnjviKkYShp8dU1LoaAgzkvhcvC7rqrUpeWtE3qsUheTP7+/PCusJk9Gtw4SV1XPypfzEt3Df6VjX0TlERPfwExVGlgacNhsQz/3Z53daCTq9yxxUJ0iJcnCrZ1t+UW4cKvmJOIrQT/dRIc+8UOWbgY50PG1y5pK27vTKEmJ9GbT+muUTF3JzMC2pM8ZZR9GoEJhvybrKS7MDkFtN0VbVHQY2p1nEohgbqHL/Ooezb4TT9QgB0+6Yc4I2IjXQPJ8tuqyjl/N+N2De18OxfRhYelYb+u4w6kozSCk7laGEv/jlwiuCrTaomMOA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 02 Aug 2022 16:09:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYpoAcjylCfZ/IlE+KXLo2d64v4K2bx1SA
- Thread-topic: [PATCH 1/2] xen: sched: dom0_vcpus_pin should only affect dom0
On Tue, 2022-08-02 at 16:56 +0200, Jan Beulich wrote:
> On 02.08.2022 15:51, Dario Faggioli wrote:
> > If dom0_vcpus_pin is used, make sure the pinning is only done for
> > dom0 vcpus, instead of for the hardware domain (which might not be
> > dom0 at all!).
>
> Hmm, but the control domain may not be either, as it's derived from
> d->is_privileged. I think ...
>
Mmm... Right.
> > --- a/xen/common/sched/core.c
> > +++ b/xen/common/sched/core.c
> > @@ -575,7 +575,7 @@ int sched_init_vcpu(struct vcpu *v)
> > * Initialize affinity settings. The idler, and potentially
> > * domain-0 VCPUs, are pinned onto their respective physical
> > CPUs.
> > */
> > - if ( is_idle_domain(d) || (is_hardware_domain(d) &&
> > opt_dom0_vcpus_pin) )
> > + if ( is_idle_domain(d) || (is_control_domain(d) &&
> > opt_dom0_vcpus_pin) )
>
> ... for it to be strictly only Dom0, you want to check d->domain_id
> here.
>
Ok, I'll send an update that does that.
Thanks and Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
|
