[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen: sched: dom0_vcpus_pin should only affect dom0
- To: Dario Faggioli <dfaggioli@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 Aug 2022 16:56:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t22pg2WEGbx9CTK1hnS8nq8iEi7EGiN8CNppeN4TCEY=; b=IvSywDL3Jb7Y1SPotq3eY4yZKODSSXd0WsP4AIB9I4bRW918nQdnbLc/tIVwUHoFSwrDdYw3aNgq8g19pDAAkknhxTnAH7LGMPE0fKte7jdm9DUaC64C9wFfIKrcxcLyHXMcRiHnalje8HBgtFz75JEu9aboRb8bEko9sJa0oq8mLsQCL2JFlSIPd72cyHkDK/EvL6kfIzGNkxccCFj0ombrQmReVbiHuE8f1SYTZCY/COzcZVf35At+kcTkyRF3/Oe/4I38KpGYpZx87SdNnXvXF8hzJfq15cvLuGpYvvvrWbhfZAvqd7jdudR9X7Tpu10BsDnR0t26a44CrTU/bw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQT5ishN34BZE+t1P8buFHyh1Ab6Gs43Liy9994iRu5Iz8nIS4felnXXF9OP/pCpoOw+4cMh4Fd/vinmBZP9MUHgBeqkJyzLensT9yK2gpEcv5TcZAEyKRaXb1c2vi0gsou+oAsfcE04efv8kuf+Xl48LH8ZEhGNo6t8rkw5N0LSA4ILEeDigeCB0iZctF/8zH35QpdF5H4MHkUqtPChPAJMFHgdhNxOEEhAHckqmNlgjGWGB5N76hmSQMCVnm9GCbohBn7DaYdvUoQXNV7MWC6QRTZ47PX5Kge8bxetWAYFTYuz7fsjkhEQlPvD+0v/Lhh45Ud7mipB1ERoQdjW6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 Aug 2022 14:57:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2022 15:51, Dario Faggioli wrote:
> If dom0_vcpus_pin is used, make sure the pinning is only done for
> dom0 vcpus, instead of for the hardware domain (which might not be
> dom0 at all!).
Hmm, but the control domain may not be either, as it's derived from
d->is_privileged. I think ...
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -575,7 +575,7 @@ int sched_init_vcpu(struct vcpu *v)
> * Initialize affinity settings. The idler, and potentially
> * domain-0 VCPUs, are pinned onto their respective physical CPUs.
> */
> - if ( is_idle_domain(d) || (is_hardware_domain(d) && opt_dom0_vcpus_pin) )
> + if ( is_idle_domain(d) || (is_control_domain(d) && opt_dom0_vcpus_pin) )
... for it to be strictly only Dom0, you want to check d->domain_id here.
Or else I guess the description wants adjusting.
Jan
|
