[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen: sched: dom0_vcpus_pin should only affect dom0
- To: Dario Faggioli <dfaggioli@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 3 Aug 2022 08:19:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qhaMqdyunHIce9EhlgnKx+Hh+XsGM/GBZO2n6H+JrjY=; b=Xjv8O7e2xTdHTDMMr1Z2fcrycwqdyL1LMOHgYMVR67scbUEYFfp0VO9wmg2fN+xNABtxBTqA2FLFfhyPv6Y0JxK06ioKImoXE6ZaYI4YIN1m+m9HdqQzJ3ANG8hZSVzpzKX/vZ1Mvg0GJeBrJuC6HPXwiAdl6ZJVQy6WljjXC8niBa6xAsYg31qV9v+0dBr897l3m4IYlQ+N6pz0w8OHkL5764E5wQT0PmgZcRMW+syzmmsMTBN1pHZygYlzSWzBxnlh0yFiezYzWU5JQ8xxlc03SI4VNDhW1u/nxpzrGT6sZjCO5fzubaMzFeBH0K1K4sz3Kkd5Nd7vWG2dRo6iPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HX1txld0schNHl0FD5NAiBNzj0aYzZ002dH/yoXIcJvvQ8JrMuwmSRBUVKReTJXDqHbXEWDykWAz89GGxOnurkmKLnpVw/iIb9X+9m4dlaHTtHJuszb086JAhtvBIWy+yKVwu5ExIVNfigiEofoIAbovM4grQgQg0UlUtglNlZJsOcstA0dFP2UhOB5etkvzw4A6Tk+sMfah85NxHnTf1p69OXkJ4kxUNnRH3ajeOHedbI02cYVS+ragV0Tn8y9bdXEqYm4USFN3mGBjpqSlje+NR4i0CDiHL3UNLo8fihDqQ9LTDBMEp00VzN7Yq4J+mNSQgA9UcG8Z52YV+oomkg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 06:19:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2022 18:08, Dario Faggioli wrote:
> On Tue, 2022-08-02 at 16:56 +0200, Jan Beulich wrote:
>> On 02.08.2022 15:51, Dario Faggioli wrote:
>>> If dom0_vcpus_pin is used, make sure the pinning is only done for
>>> dom0 vcpus, instead of for the hardware domain (which might not be
>>> dom0 at all!).
>>
>> Hmm, but the control domain may not be either, as it's derived from
>> d->is_privileged. I think ...
>>
> Mmm... Right.
>
>>> --- a/xen/common/sched/core.c
>>> +++ b/xen/common/sched/core.c
>>> @@ -575,7 +575,7 @@ int sched_init_vcpu(struct vcpu *v)
>>> * Initialize affinity settings. The idler, and potentially
>>> * domain-0 VCPUs, are pinned onto their respective physical
>>> CPUs.
>>> */
>>> - if ( is_idle_domain(d) || (is_hardware_domain(d) &&
>>> opt_dom0_vcpus_pin) )
>>> + if ( is_idle_domain(d) || (is_control_domain(d) &&
>>> opt_dom0_vcpus_pin) )
>>
>> ... for it to be strictly only Dom0, you want to check d->domain_id
>> here.
>>
> Ok, I'll send an update that does that.
Well - if you agree, I'd be happy to make the change while committing
and then adding
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
