[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/char: imx-lpuart: Fix MISRA C 2012 Rule 20.7 violation


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 3 Aug 2022 08:16:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTtNdVDYFrM1I1LvxUSxHYlIaMDDTH1sjtZmGr8g4oE=; b=oFInQ3ZaPScAajU8al3VVp41/k9qchY46UccnKj1BQSID38bmCXIfRz99vb5laFwBUS54qhnswbx9TIYU+QPEP9WgmKx1S9ZbievveCiiok42vfaZrfPY50iunpF5dUFrg6yns43zHyUt3N9wcBQMVji+SUynxYIMlmzbczS2nnjfmdmBWstt5tLJSnkR/Jz/xqCa3E/pWGwNh0uVii3pr5FOWfBP7i1KPGE5LMkQVVKxjrUHK0amgM5y8rZ0uIPwSrVohuTM0sN007pL6PibUTrqkrmYmb31/VDf6WiUNO6VzvReEy2CupOWZuJSY34mk6lzpuED5DWJWblQJVyuw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qcf2gMOg/LSEEmmjJDr7mb6sijr+p568Yyto10AG6q2mNAB+R7A1haKT9zdn3Pbg6W4FQ5wPjvcD+5m3OwPwhDSpEf2M5FMfY1mvT+Q8aQfHmYBJBk2+cCaHOFgUigop8L8r9buAJ25eoEC3X29hm2LUb+Ay/imaaGZACBjQIWII0Bo36M/LVZM2w4QJDWaFtLMpQO1vN7NHjo2LO8eRVK5bolEuq3PQwhIolX874+KnOOnMVlKxFpvvo/Y/NFRU2XDsm8i3fN6c9wNEVkhu2cZxpL+tUGq+EPnIRgJRkx+M4pkZefTp7EtzQ0meNsKN7PV8DraAVZgZr07aGxi9eg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 03 Aug 2022 06:16:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.08.2022 00:58, Stefano Stabellini wrote:
> I think it is better to avoid asking for changes not currently in
> CODING_STYLE and docs/misra. It is less work for both reviewers and
> contributors to add the rule to the coding style first, then ask for
> changes.

I very specifically disagree with this statement: Attempts to add
text there have been ignored altogether, i.e. have not even been
seen worth a comment against the clarification and/or addition. I
have therefore given up to propose changes to this document, and
I'm also not going to suggest to anyone to make any attempt up and
until I see movement on the adjustment proposals already pending
(the two of them that I can easily locate for now over 2 years,
and iirc there were more which predate our switching of email
systems and which hence I wouldn't have in my outbox anymore).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.