[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 3 Aug 2022 13:42:01 +0100
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 12:42:25 +0000
- Ironport-data: A9a23:enCK4aBjUjAmsRVW/1Hjw5YqxClBgxIJ4kV8jS/XYbTApD4i1jUEn zQaDTqEPa6DZ2b9e9kiPYzi/ElXv8eBmtJqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpEs/nb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW3azm7ZqVB0LBJQ3xKFPXk0Q3 tlIcy9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDeLkFYtiuOF3Nz9dNapX+9Fk0Sk+ mvdoGvVIBQkbMC01m/Qmp6rrrCWxn6qMG4IL5Wn8tZ6jVvVwXYcYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Riy6VD3YJZiRMY9snsIkxXzNC6 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBWJdPWwAFVc42sDMnsYL0T6RZfMzS7Hg27UZBgrML yC2QDkW3utO3JJTivzmpzgrkBr3+MGXE1ddChH/Gzv8s1gnPNPNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83oJrW3FF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPd/gV5p3kfK+Toi0PhwxUjapSsEpHDJrAQk0PRLAt4wTuBJEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqKHfjTkkX4uYdykVbPFt/pxnPSMb1ihE5FyS2Jm +ti2zyikEoOAbSiOHCPrOb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog==
- Ironport-hdrordr: A9a23:ZPc5Ua+2fiO9HoeOz4Buk+DYI+orL9Y04lQ7vn2YSXRuHPBws/ re+MjztCWE7Qr5N0tMpTntAsW9qDbnhPlICOoqTNWftWvd2FdARbsKheCJ/9SjIVycygc079 YHT0EUMrzN5DZB4vrH3A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Aug 03, 2022 at 01:58:34PM +0200, Jan Beulich wrote:
> On 03.08.2022 12:57, Anthony PERARD wrote:
> > On Wed, Aug 03, 2022 at 10:24:26AM +0000, Edwin Torok wrote:
> >>
> >> -ifneq ($(MAKECMDGOALS),clean)
> >> +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
> >
> > I think it would be better with $(filter-out,):
> >
> > ifeq (,$(filter-out %clean,$(MAKECMDGOALS)))
> >
> >> .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile
> >> $(OCAML_TOPLEVEL)/Makefile.rules
> >> $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli
> >> $o,MLDEP,)
> >
> > Also, don't hide this rule, instead, hide the "-include", there is no
> > need to have make waist time trying to find a rule to make
> > ".ocamldep.make" and failing when not needed.
>
> Hmm, this sounds like I should be reverting the commit?
Well, it's not exactly an issue as there isn't any alternative rules,
and make is told to ignore failures to make ".ocamldep.make"; so `make
clean` and other targets still works as expected. Just a follow-up patch
would be fine I think.
--
Anthony PERARD
|
