[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] xen: Port linkage.h from kernel code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Wed, 17 Aug 2022 08:56:09 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RO3Dsy9FTZ6YBHUYjHsquha1W5vGYWD4H1FBByp7YjI=; b=cMvfsxF6+cGOLYimzVGQoRQFtAFbbWsNfXSQgtm7zjNlNrXKJShZ/c0+f54BlDT99RiGYpcdZjyPOe3AnQCthlMU9voot6+7MDTNr1MRc+ihnsWY6MJGL0nxefSkId2epQKqnGCzzroUmOsWZdlD1c7qaD8hT7YxV270FEfWt6u2PSWNSIzXGjgE7rAtz8xIshG9Irp/+ZgSHxZk5MDxPt9HpLGVkzLP8etEBv2F0rgdb93A0+2xaciKB7OJ/6omUAgCNNKo8jcxbjEz9ZWTP110CXUWflqdJ6wMH4KxJFBZq6jT9GgjQseLhYMOk9wda60NCbCY8z4UF+CGZX9zuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k4rutlWcVivV/rvJa1XPp3g+zg0OMDnm+MrZDT2NrL6BnB5lAsY8RT5x8+bnqv9r1co2svbsPCEzqiPck8LQ45TwVrWYEinGQ5wlOVUlbOFPVSH2/mqTCAvXKGfXYnmIGMCpeqh0xevSKoYO6VsWS8VB5Cj/2S/kTJKWsUcH3psNiIZm/BAN6mMP4cDpGBTx9Fmm+WkZoAahhy4+Bw6PGp1PCpdWhTWdBQzqN8h1gFIGubQb0C/rPHJPsCOH98BUp30r1XXu8wTeN1dNiimDjJgGa6T22CeJxHNOnQOS+ZRrWutC1NvPTHGdeoeDlu3R4YfHnt1oyJsGt8s02Y0MmA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 17 Aug 2022 08:56:21 +0000
- Ironport-data: A9a23:OaqNW61pJpB5MfYKHvbDix16xVZp2XFdZch5A8VEjyJ0xrEAwtozkvJmspFDY3Ohlcen9eFSkeUyjDOjoXlbgMmZDsEs7TctpWDqINIANP88zg/yPWWGecd9FnQX3ncgycBs71oBS9KM3BXuAcsPlCGP80F0MM3bxrrQXUAWbvjEAFOywlPIIqpFdJ5P64naGXmhe933DWH25WK+fQzSkKYplGOX7+eJ8v/TLPD7t5OaxS5Gj07D388RhnVnlUYFmRQ+hopI7VNglnWAlku1QnBUAke6mQUig8xH1rMHLQ8O/0ohcw0w+hBRr9b5mH0CsPAyCKXh6ZfyPcSwDYSQxHYjgULg/OVnxeBvRZi/TMHr0We8Q651xR3UqSDN1MN6mJ9BccVe55RB4zkxv2rN0nRBvd/q+SjgPPcFAS9QQdC7fZt5OyGUBfaQ8RRngmrsl7Sl3dgx7/ljGk39kxcxPn8y47b2H4pZbx/IqQkb3oeeUTr+liB3VDOjJtm9eA5xwfDus4sRTfL532JG9xs/H0luDlJW9IUTUsl1Msr35flt7dFEt7Y5MDeIuRkigRFRROJLnFnFbQE7xxmX8KrtTV655vQ2qDXwG6EKIQnaDiY0gYV6399hPHIRQwogqpDnp6gYzPaxCAFBbsfduSbihriYfi7xz/bb+5HDMQl5BQWTRw3YPRByFhsB0ASdn/Eq3yazOH3nK7SY+lT8jJkZ8jSB1J+1riRD8pLcWZAwXnh6Z1bLkdvjgPRVYc5VLi8A8GEUofFJtFR78EMGmlaG0LKDcEqnEqhu5TWxsw/yudWKEfrdl2NPAzRI2NDMpvNi/XZngn6rk+gUtL/OkuqRa4WappEktn2ZTpeaPiBYpEVFy16hrXAOQmjbNrsI0fIDoTMDEUZb1ZMvk0K5dsB4YtWBsAj2i25KACaZEVkF/yAPzkAGkOisbsSDJFhiAB0O6THz+/CuJrvFpDHdUWHKpz8bEBK9zWDsl2FrxOmOFBMy2y8Gkau6dJzxb5eVW9zHXFjVEAiS1I3KsWgMh7LPT3q4KHUcPReda3jgLGUgrPcFUrEgZy57+aReYRGC9Jwm2VV5J6m4+P6RFqNujS9flQilml0eWDEFWlYaBoXuB00je5Chm+IMkQYJlAHIMt9gvyiQIOLUZmJkl06TBvW80UZJXu3GPFqLjIKeljT0h9dk343m/cpAY8v5L/W+MqfkjGWujW+njRa2On2v3G8Mx1ypa1SS61G8CQ4ytUrc3CURPnKoPF+WsX7x91UQgMNHAgBPzMz0DPsyi15Z6dAgKZRwqOjqiRYCAYSuVU2ScamG5w0y1ZAR9GZ0evbytZBtkQ2byauptIaWog4/UfQvzcVjZVWkoC9yE9o6uFs+CWe3+woBzaUiUfalNo5kN1JoP8eavPxT6QC7OgaIZHZsjx3a86AhtynHn1jcu1vZLPvQH5AK2yaWUqIaBoKbWcDyb663L01ekhhYo5osrv+RH9wmiW1JavPVvpu1F5fgKmY7TCEgwoZDN6jOgWCppN1gXqbqG+bCFdWtVYhCj8siw5w9pxfC96QpFBhHInqxEtUFu1Di9O/7lvTsCf02h/Cib4YzVfVjlZfEURLyzLWMn4w6jObwqHKTwnLlxZyzMSUVs2THkE6lR7jHne59lz33VhXlrfVYtzOSe6NaCRPCNEBoqk3Lcq5TPRCcCbbwGP/hD+uMXer/17JhKIhraFrt7CyKvDrcKxryLAHzl2u08orKaA3VS/vbhCIa2rN6u3TMoDSq3QctqJtDGulSytM3z64eUoFH7pHobsp11eX1hIpCPqMrbFUS+oks9wNy/V2s6Vy8MJBRPmK66dHssEwdKbBHxSDwVDgzBCTs3d5VahWZz7izP2bR0gQkOj6bqupxBD6VTq8bctrKqkTkpeBfh9IluZ74GZTsgWKOQ3OU9x/DcpvYSDzvGXQggwShJWY3liLwFY06laX8A7gzahT5JHG4GBMThOUP1MUSiOMRDPgS23dajOnJCKzSrVfHsEjZUcLbWa7gbTIeARG8Ygax/UgZjqcJNhJOZIfk5/iTPTFvQNnj3GqxG6rIxJ1fnTjo/v3UAvl6xqaHNkXWCwMXSQ6Zo6orsvbSPx+odJHDHrKQ6E6ttFkbxjmRViCzgPSuqnMYTE+9JOWCTS7jy7IQ6XZTfquEDn+XCsiqPICaQEYUu2TOFs2UuYmpgSV2JzT2dsrVWEZQGN60NNGV059ApZvgFCL6FCIQTFN8wdQeywz9/3W6atimjE/pcgbDPthdx6GkdqAp6+t6Kdr0jviWgRw/akgWCikvz28bdG64seUUe1tymdNt6IooEBf97B/dvWDrxFzZ74by+XTr5QMvov7EMiEDjgnc21SiqDjjI+WP0kB5muj6ZXvmghBtAXrOyuBISS5FJzAQ/2R9qamHSHL4cMdOIy3IJgjPMClUPW/3
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYqBOcTorV7/AaXU+jvacxRyO/Ya2gCkGAgBFX74CAAC+mAIABTFyA
- Thread-topic: [PATCH 2/4] xen: Port linkage.h from kernel code
On 16/08/2022 14:06, Jan Beulich wrote:
> On 16.08.2022 12:16, Jane Malalane wrote:
>> On 05/08/2022 10:24, Jan Beulich wrote:
>>> On 04.08.2022 17:04, Jane Malalane wrote:
>>>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
>>>
>>> In the title you say "port", but then you don't say what customization
>>> you've done beyond the obvious adjustment of inclusion guard and
>>> adjustment (actually removal) of #include-s. How much customization we
>>> want to do is important here, after all. I notice you did, for example,
>>> add new flavors of SYM_INNER_LABEL, but then you didn't add anything to
>>> use .hidden (which I have queued as a new patch on top of a supposed v2
>>> of "x86: annotate entry points with type and size"). At the same time
>>> you've left in objtool related commentary, when we don't use that tool
>>> (and no-one knows if we ever will).
>>>
>>> I'm further not sure I agree with the naming of some of your additions,
>>> as they appear to not really fit with the naming model used elsewhere.
>>> Your additions also look to not always match style used elsewhere in
>>> this file.
>>>
>>> You further want to mention what Linux version this was derived from,
>>> to make it easier to determine what incremental changes to port over
>>> subsequently.
>>>
>>> Overall I'm not convinced this is a model we want to go with, first
>>> and foremost because the commonly used macro names are too long for
>>> my taste. What's wrong with ENTRY() and ENDPROC() / ENDDATA()?
>> Hi Jan,
>>
>> Since I have no particular opinion on this I went through the discussion
>> that took place before those macros were introduced in Linux. One of the
>> points made was that PROC was an ambiguous term to use, since C
>> functions are not actually procedures, at least not all.
>
> Just one remark here: We're talking about assembly code here, so what's
> a procedure or function isn't well defined anyway. I wouldn't, btw, mind
> ENDFUNC() if that's deemed better than ENDPROC().
Do you then propose that we use ENTRY() and ENDFUNC() and that for inner
labels we keep them as is (so just "name:"), since using ENTRY() without
a closing END() for some "functions" and not for others could get a bit
confusing?
Jane.
|
