[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value


  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Mon, 5 Sep 2022 16:51:25 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=GbPxE2Fp41hXuwQhstMgO9e6NQhZpRHM4GN/UeaUNN8ERvZt4lFNce5a7022NtYC3gxcuyrNwsSxhKqGYYszK82RCSGRqmvDOf6kT/I0kzkSWUNRrP1DqbVpmkC/YQMHUUc3OxscpEC8v2GVwE73Z8r5/F1R/6NagBXEESBFMjh+J/p3HwEe1mhpPjDzD7a2Twm9eVKG6R8TL6d99tikENdBd8f0In1+raBDUUpL2Lnsa8Sns67Royx92/wLjCpEsvEt4QjgB9vi19byp/yGVloIzIjXN7JJ2Wc04UBfRPEfXzRHhTKQWoWDfA+T4EkItDOXamSWzKl+XMeYPOyzHA==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsgTKyBbntCDVmvDXzWwWDFlH7xshsqNUPBaVZnVGbE=; b=ban6PjwAXR+NVfWlTlmBd/PI4DxuoqLEfOw8JRjbb3bF6bmTfQq6j5qTQbN+iapclq+/Ncc/qy19MYap1pE8OkfzLQWeToRHpfquqwfgaVcKRwtqzc0RWUNI+xJ1PIVDwM8XiO8ZOridlzgqyt+BLeJE/F87SZQAW5elyq9MyX/km2pBf+NJvF1663otzRWVAfr8K7yBKU8bgKoSPhbP3huLBa236YP965C55gWmw1D87H5UlRbWMLc0phO+R1xu/w21WAH2yVdpVQLdmi/dO+OSGhaGW7KnV/DLEeHWBPcG9oKnyu+c9r+vLrdR4lp+YePk5Ssd1nlzoXCTWxnd2g==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dIjjKstNPTJEcQ8sY61Gr5hzPeEkAXaADi1ZpajI25yBuMPJIX3iUIN2du/GyyvmkwBBISMiKLaKCRPQnnpAovR1BudQGZutwPtVAHsYWR6Jot2vej7WK0/j9SJYzs8PnsrHJWEL5xldJ3ZPewbAy/U0Rbx6Ms9M4mGnTJKzJbotmidHsbh1fjs7aqMPG+qixH5251gihF+qFyIyz/mYRMK56j8w7oZHYBtE05FYCYPFCZP67KOhiZyTSrjQ70dD0U/z76FYsMK/1LC+DB1oYzX+MDAZNrMucUCmJjP1vWEttdfvg9DBM6corz7Se9QLjZBubUfABpzR7Rni9lwllQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEhTFL6T1pr6UYCA15zeJv9d++22iF/5VbSbNttjW8KVsDqkyORwgc24Bymu+WtKBvuQHn9wEVgbi2Z8DGx2yg7Vzv2NWJaB0vTRQ+v1EbrqKgu9xv32qhMhykuCvtVsrF5RbPJ59xROLanP976zBAxAOO+GIZ1OVW4B8kY9qG340S9MX7D9U9M3e4Sqa1Lv9mfXVwtoP2nU1/cCrnQaEL9SWXhMUnzDHySsAeGnjFDVgSWGe2YtRplRDVE7eUO18nYQRoaSrsSEHkiWbliOe7vu7CerGVSUOIfyLUEcDGHCyuon5aIrbmyik8MIXcNHhi4a7ASLze9fBUuCdiJKjw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 05 Sep 2022 16:51:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYveOA33HU3e+ak0GIRMMly1Yth63K4ewAgAFZKoCAAAQmAIAADY6AgAAHOICABGESgIAACJcAgAADEwCAAAPEgIAADnWAgAAKUACAADNYAIAAAxEA
  • Thread-topic: [PATCH v3 7/7] xen/arm: introduce new xen,enhanced property value

Hi Julien, 

> On 5 Sep 2022, at 5:40 pm, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> On 05/09/2022 14:36, Rahul Singh wrote:
>> Please have a look once if this looks okay.
>> /*
>>  * List of possible features for dom0less domUs
>>  *
>>  * DOM0LESS_ENHANCED_BASIC:  Notify the OS it is running on top of Xen. All 
>> the
>>  *                                                           default 
>> features (excluding Xenstore) will be
>>  *                                                           available. Note 
>> that an OS *must* not rely on the
>>  *                                                           availability of 
>> Xen features if this is not set.
>>  * DOM0LESS_XENSTORE:                Xenstore will be enabled for the VM. 
>> This feature
>>  *                                                           can't be 
>> enabled without the DOM0LESS_ENHANCED_BASIC.
>>  * DOM0LESS_ENHANCED:                        Notify the OS it is running on 
>> top of Xen. All the
>>  *                                                           default 
>> features (including Xenstore) will be
>>  *                                                           available. Note 
>> that an OS *must* not rely on the
>>  *                                                           availability of 
>> Xen features if this is not set.
>>  */
>> #define DOM0LESS_ENHANCED_BASIC     BIT(0, UL)
>> #define DOM0LESS_XENSTORE                  BIT(1, UL)
>> #define DOM0LESS_ENHANCED                 (DOM0LESS_ENHANCED_BASIC  |  
>> DOM0LESS_XENSTORE)
> 
> The explanation looks good to me but the indentation looks odd. Also, I think 
> it would be preferable to use U or ULL (if you want 64 bits) so the size of 
> the bitfield is not arch depending.
> 

I will fix the indentation when sending the official patch. I will use U as I 
am planning to use uint32_t.

Regards,
Rahul




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.