[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
- To: Christopher Clark <christopher.w.clark@xxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 13 Oct 2022 08:55:33 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=; b=QTHAUEN8wIpnfEoD69SE9O3EekEA783Z0c9XbinbHb9SsOEVpgmxpnnJ9/+bV3Mku0+oX8uDi967OL/a9mdTQLxflSDDYjApQWyR2+gTiTYQYF+jwsA7WATTM0UdQHiNKpg+PyDk0jW1lxyOK4HT+JFQLcKaTF46inANNmzHNHz2Fex3n83CrFmZefr0TvYw0oM1R84i8lR4zLZ9cbVzMOwcmkcyPMYJLx7lc5SbjNnHyU7S9SZYSJhDinabb2GUs2xzXVe1gaQaEs/q/+KP9WpVr4IOeUe5lGlhT351TyyUsufOIuvGxgCHJKIlNM1j94jQjj1uThdOunDv5NH/eA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=; b=ggvaCQqMI4Lamfxzp0bq6TGHledWnicJot0keRZ89dbC4GbKSfa2Sa1B5J4K3DZDsEUiH4+kbbZSxcuZMVsEvKhWzkkZuRc6MabmilC+vFv//uoL9G7EB5LQa5adFKEYAILD6L+wlhb1d8lvIDWvSK17jb7T8X7gn7Bnjs3NaKEKwbu393MxKt4Pp2g/rZbPM6Ms1E/Bdei+Zo24+/ekpd2wSruCkc6Od8M/Y9aIZMd8cBDXNktU2PuWDVyVSOfwNl/gskT97SWc/qHVOuIzPaOsZBuHYhvwzRn6CioR0s+MMr444jDOP8kxVk0NNTC70M0Lw8oZ/+Tb3W22RjpT4A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kPunFIc2QdTUBDoA+ZVsO1Ail0pG8uptUwwP4/CD0Fiwb0n14FoPHsSj2hgKD2NXx7G3CPXby71Mf7tv4w82QZe5M/QktTLVdMklHNhNhnd49BNYJ7Y9gb3wnvtgbtZHWnma6pY/tbPfKscM+LcfrvoUfUhQRY3Isrii2gLbBOzoRc3cfgaQujL5iIVr+TU2qwG7uoeylhC/iOYgV9M19EwGnIhKCcSnt/CEpUyNqv3Oh2ShvHjszLqoQA10aRndRkQ6TFGcrgipvENw/MNRqI8arcfbmYcR/ea0HpeoXjIcAKPxKZl/SFn5E/4QhK8xE/sP7LbHBqJwQdN2VNqQ9A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHAqkdZA5Lm47D8bSxiCrp4YDLOj0UACzK9Payn9HJCGy6/cET8oVgg5yEqbWMOoGnOeZ8nG9YntTv8JsjtEEWd1TyqqTLoecJraOd9m2djeUiku6zcyMUOrNwxe2ObuC9QefZ7/lXu9LbrunnLUIgok/4qmtpC2EaUmPCvc+kBh2bBqHFmxODYCYihyXVwwB9qkjyeRrO1ISwK5wqbXN4vn57t6XAo2E6YOLfFrmGz7ykWxgTNhD9xI7Nu63NWljaPt3oKLjZamHFwNXxdZp91I2+Fwx7bDlqR+YQxSnD/xB7oQ3KB61XiVuvKY//ABwN1gI6NFRlmBr+zRFpWmdQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
- Delivery-date: Thu, 13 Oct 2022 08:56:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY2oOIAk0kP8Ly4EylVwyMRp/g6q4DWdEAgABVmDCABXKqgIAC6/6Q
- Thread-topic: Ping: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Hi Christopher,
> -----Original Message-----
> From: Jason Andryuk <jandryuk@xxxxxxxxx>
> Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
>
> On Fri, Oct 7, 2022 at 9:12 PM Henry Wang <Henry.Wang@xxxxxxx> wrote:
> >
> > Hi Andrew and Jason,
> >
> > > -----Original Message-----
> > > From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> > > Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
> > >
> > > On 07/10/2022 20:31, Jason Andryuk wrote:
> > > > I observed this ASSERT_UNREACHABLE in partner_rings_remove
> > > consistently
> > > > trip. It was in OpenXT with the viptables patch applied.
> > > >
> > > > dom10 shuts down.
> > > > dom7 is REJECTED sending to dom10.
> > > > dom7 shuts down and this ASSERT trips for dom10.
>
> dom7 used a wildcard ring, and dom10 connected to it with a (driver
> level) stream socket.
>
> > > > The argo_send_info has a domid, but there is no refcount taken on
> > > > the domain. Therefore it's not appropriate to ASSERT that the domain
> > > > can be looked up via domid. Replace with a debug message.
> > > >
> > > > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> > >
> > > We're into the 4.17 release process now. A bugfix like this obviously
> > > should be considered, but will need approval from the release manager.
> > > CC Henry.
>
> Thanks, Andrew.
>
> > Andrew: Thanks for the information!
> >
> > Jason: Would you mind adding a "Fixes:" tag following the rule described
> > in [1]? Thanks very much! With this tag and proper review/ack from
> > maintainers:
>
> Of course. It would be:
> Fixes: 82a817307c5b "argo: init, destroy and soft-reset, with enable
> command line opt"
>
> > Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Thanks, Henry. We'll see what feedback Christopher provides.
Since we are in the process of 4.17 release and the release is supposed to
happen after 2 weeks, may I have your feedback here for the patch?
Thank you very much for your time.
Kind regards,
Henry
>
> Regards,
> Jason
|
