[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Edwin Torok <edvin.torok@xxxxxxxxxx>
- Date: Wed, 9 Nov 2022 09:21:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DLJsNvHDALY0jAq0emL9Sxhp8HyNQccgjSFLDh8mNBo=; b=RCqUmpZ/GzJbm1So/3ub7ew4JolEFoK1U+uF43kxAtSAP/m3hFD7bSPiJD9Xia6BSmRrYRu682d6D3cVzqoS97uUzd1LtMTJ6UKtLWD8p54HgzpaqjAH0kxJXUwLo7Mkzkqfeo5P++E/RF5VnjWlYnRh72Nk+BNGYYGYI+VAsf57sh2x5SqBdicu0KXU3EG80efpz6kn5Xe04dmAIHeLCpfqDMYC6S33p9KWLVJDF/2t4lxCHH5MNjAjnPHQ3HrGUNH8dhst4AqNdPQJYb2yLXiGz75iv+PBHMaYu6+IOh8Jzc3oFc85ehAGBhaBx37EDbJvwezRolhcS5CCxp8uOA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cgg7mjHFh66e25hGpy4zDhJGQtfzCH46Z/4Zd18jOgsfELA2xpv+0LtqSyQKrsgp2hvkNqYwxByuS3Chh3Ajs/4GVVFC8FSKzNBshMdrSgA/Fm0eel22mGiykCqvdZVRjc8WUz+jeyiNlbLWXOKO4mZHlfNncpXEwU9xJPHapEXAiIgIAeOSHP3UsMBf8O/XPQaRVt7s9kjeXaoHLy7mzevXmv0X4tnXM22lc35IqUPuNCkrc+pvzege+jqoAp26Wqw2AMsUsy9penswszq4ZVecCRmRr+dVw2oZBYyutIJVaU8DUcvr6ms9vk4u3vuVAyCGY2Aa8e8BnTtUh60tEg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Henry Wang <Henry.Wang@xxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 09:22:21 +0000
- Ironport-data: A9a23:7Tay4a6O+IznVXAQ+l2MJgxRtPTGchMFZxGqfqrLsTDasY5as4F+v mcWDWyAOKvbZmTwe9l+b4S080gEuMWBmIRnGwNqpCg9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT7QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 a1HBTVSaj65rMWrza63VeNUvfg9I5y+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOiF3Nn9I7RmQe1YkliZo CTa+H7+ATkRNcCFyCrD+XWp7gPKtXOnAN9JSOTinhJsqGGQmmk5FhwWb3aU/d2z1x66fNZ7a HVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4orZ5RyIQFcNSDFpYcYj8sQxQFQC2 laXkvvzCDdosbnTTmiSnp+LqRuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+8VWZhTup/8DNVlRsvlWRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg==
- Ironport-hdrordr: A9a23:CbcWf6Brb9v1THDlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY84enx+9R1HXBN0OC3OTqctPuu6415EUAgABJboCAACSeAA==
- Thread-topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
> On 9 Nov 2022, at 07:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 09.11.2022 03:47, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Edwin Török <edvin.torok@xxxxxxxxxx>
>>> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build
>>> error
>>>
>>> Building with Dune in release mode fails with:
>>> ```
>>> File "ocaml/xenstored/store.ml", line 464, characters 13-32:
>>> Warning 18: this type-based record disambiguation is not principal.
>>> File "ocaml/xenstored/store.ml", line 1:
>>> Error: Some fatal warnings were triggered (1 occurrences)
>>> ```
>>>
>>> This is a warning to help keep the code futureproof, quoting from its
>>> documentation:
>>>> Check information path during type-checking, to make sure that all types
>>> are
>>>> derived in a principal way. When using labelled arguments and/or
>>> polymorphic
>>>> methods, this flag is required to ensure future versions of the compiler
>>>> will
>>>> be able to infer types correctly, even if internal algorithms change. All
>>>> programs accepted in -principal mode are also accepted in the default
>>> mode with
>>>> equivalent types, but different binary signatures, and this may slow down
>>> type
>>>> checking; yet it is a good idea to use it once before publishing source
>>>> code.
>>>
>>> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain
>>> shutdown"
>>
>> Nit: The format of this "Fixes:" tag might need to be fixed?
>>
>>>
>>> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
>>> ---
>>> Reason for inclusion in 4.17:
>>> - fixes a build error in a previous commit that is already in master
>>
>> Yes, given this is a simple enough patch:
>>
>> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Afaics this patch was previously posted in isolation, and it was
> already release-acked. What's lacking there is a 2nd maintainer's
> ack or a proper R-b. When it now is patch 9 in a series, it isn't
> really obvious whether this could also be committed in isolation
> (it looks like it does, but a clear statement to this effect
> would have been beneficial).
>
You're right it already has both acks, it just hasn't been commited yet:
https://patchwork.kernel.org/project/xen-devel/patch/5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@xxxxxxxxxx/
I've added the acks now to my github branch, so next time I resend the series
it should be there.
It can be applied independently, I've rebased and moved it at the beginning of
the series (there was just some whitespace to fix up)
If it helps here is the commit in isolation that could be cherry-picked onto
master:
https://github.com/edwintorok/xen/commit/da88b438e03da36212d07d24d67ab151ae287f4e
Best regards,
--Edwin
|
