[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 27 Jan 2023 11:47:33 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNfAuDjB9ohOLCAlbAU9zSwBfbCvIFOHixWRJVF6lto=; b=W4/8vj5tsY8jJjXvIq939L/OuvPJxf7pn23qUeV0HrEIKRRbVBtlfr/ISl7Qjr4HwtNkoJFbCmqM3uhp16tgj0f6ubMmtKT/SL87hi3B67nHuM+38YOxLM0TgDns5RetH82ZCmf0rLZCu04GYf/oAFNrQaQCfsBknue9mcCK3puuhWi/gUnprXLu/dKA54+FYTztUObtJ7K7H0PgGhVRz41n26ov4+GNa9SCAzyDzEG40+IfhMslqYbJHgedzNGX0oI2fblQ/Ey/bVO7UHyjF2axhE5rJK3esBZA45v9UHKiBAKILwtph0hw1LnTM6C0v2IrZ2q2BUPAkJawSXRtQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xi/nvl8/5SNu/2quC1r5gsSSlmAhB5oKHDwYbl1m77KsxpiGfFvjfPIHTs+VnTRkfUIaJNsuTO0DYZW3t7RLcCt9PwE3v/waHfJ0CnQJyDmcJRMXc4U21l2ZeSkM+wGZz4KVsi8vt44K7UtLqMgSkY+kVlGvPwxOOYvmmNlyNUGuEkK7k7G0FVNavkc1VrcRKaTIl9uMYIF0er2xM1rsOmQ4zEfZbNA5FBfBrr7BujDiDbY9kMZTiy1p8Kp3EgIuu3AB/GDHd6Hq61UUMTSF9PQUAybFiqweHrVqvnLjNLrLsTEb/HTp/HhT/UZTndWsJIOwbMlTUwSfzzvwgcTu1Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 11:47:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZD2qaLVIiQ3Z13EK3E/FV+D1Sxa6vQakAgAMoxuA=
- Thread-topic: [PATCH v2 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem
Hi Julien,
> -----Original Message-----
> Subject: Re: [PATCH v2 1/3] xen/arm: Add memory overlap check for
> bootinfo.reserved_mem
> > + printk("Region %#"PRIpaddr" - %#"PRIpaddr" overlapping with
> bank[%u] %#"PRIpaddr" - %#"PRIpaddr"\n",
>
> AFAICT, in messages, the end would be inclusive. But here...
>
> > + region_start, region_end, i, bank_start, bank_end);
>
> ... it would be exclusive. I would suggest to print using the format
> [start, end[ or decrement the value by 1.
Another good point, thanks! I will switch to the "[start, end]" format
in all 3 patches.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
