[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] xen/riscv: initialize .bss section
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 3 Mar 2023 10:53:44 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hh8w1BXwTXVSFyizCvuLn1UHWxFa2Bg1nH6pCG+3RmQ=; b=I3tmOTQ34m8phtdxoNjwwCmDrsQ3rgA0wIApP1LmFrtenStjt6rYq4ZCOKApInfyaY7oz5/8UFAH37L8bx8pEyl2wwMOmiv7rtac56YSb3ak1e69F/Cj/jayU/0s3uJjNyPoyLkEr/apcsA+KTRC8Z3btaYkFwJLMzcAQiRymPzPETRlvs7XhQgdIz6F/OUz6bLTs0vWHEpA0x4ZauM3el9xGVSOG8hin4eznqGcKd4RvtOyHkNXr37kHW53xkBzaF/FR24gONxT63FWBAXXSHDB4kkAISi1fJLdBbfNRUapvPTRPLD/+ZoVEvzCCgU/f6y9ibpZDEeb/yMZEg77DA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oCGqfhAokRIBTCCBjejJ7sWEScAzRN3PPr7tyblIP4L97q9IhyBQ3kRThw3O3u9hOHWtISBcPnZlIkmbXrCbvYpQqTSJmBa1rPgx2XNjtOvmIABBX3rT5bcwvWQAvvmC9p3ZMkJj3K/z+DIhdOdweRx/OIQKf5CHN/kvnWMHd19MfiHJ4HD8gpNVdTOwoJ4vNimAJ0FUNwmmxNNUqz6tlqtD7zqhQx5aWq42pLoU6IpZd0BAh963agmdGdIzf/50AuuAW1ss17PoufIdjimsgvJNwskJrlFkTGlONC/+Aw2yGeRkycfXvPX/UguvplkLFvsMcMVfSsZ6Fspop0jHAg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>
- Delivery-date: Fri, 03 Mar 2023 10:54:02 +0000
- Ironport-data: A9a23:Na+RlKpL7NHG/usDLm1mBLE5AE9eBmKyZBIvgKrLsJaIsI4StFCzt garIBmDP/rcNDbxet93PoSw8R4HscKEy9diTgFkrStjRCNDo5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weFzyJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAgATiqHir6V/LGAQa53qu0DNPfWLIxK7xmMzRmBZRonabbqZv2WoPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+SrbIa9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzpqaQ13QDKroAVIAcXX1nm/sWWtny3Ad1TJ V4kpw8LprdnoSRHSfG4BXVUukWsuRoRWMFREqs59RuKwarX5C6WA2EFSnhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqZyUJUA8E6NnLu5wog1TESdMLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1V/GijSou5PAZhQ0+ALMX2SuqAh+YeaNbYui40nW9vZEIYOQSHGOu XEFn46V6+VmJZiJlTeRSeQXWr+z7vCOMSb0nlJkWZIm8lyF8Hmle4dS7DhgJVxBPcMNeDuva 0jW0T69/7dWNXquKKVxM4S4Dpx2ybC6TYi5EPfJctBJf559Mhed+z1jblKR2Garl1UwlaY4O tGQdsPE4WsmNJmLBQGeH481uYLHDAhkrY8PbfgXFyia7Ic=
- Ironport-hdrordr: A9a23:qzk3bKBW2MrVj6nlHem955DYdb4zR+YMi2TDtnoddfUxSKfzqy nApoV56faKskdyZJhNo7690cq7LU80l6QU3WB5B97LYOCMggSVxe9ZjLcKygeQfhHDyg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/03/2023 10:42 am, Oleksii wrote:
> On Fri, 2023-03-03 at 10:33 +0000, Andrew Cooper wrote:
>> On 03/03/2023 10:24 am, Oleksii Kurochko wrote:
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>
>>> diff --git a/xen/arch/riscv/riscv64/head.S
>>> b/xen/arch/riscv/riscv64/head.S
>>> index adf5d6c74a..8887f0cbd4 100644
>>> --- a/xen/arch/riscv/riscv64/head.S
>>> +++ b/xen/arch/riscv/riscv64/head.S
>>> @@ -18,6 +19,14 @@ ENTRY(start)
>>> li t0, SSTATUS_FS
>>> csrc CSR_SSTATUS, t0
>>>
>>> + /* Clear the BSS */
>>> + la t3, __bss_start
>>> + la t4, __bss_end
>>> +.L_clear_bss:
>>> + REG_S zero, (t3)
>>> + add t3, t3, __SIZEOF_POINTER__
>>> + bltu t3, t4, .L_clear_bss
>> Using t3/t4 is fine, but it would also have been fine to use t0/t1.
> Yeah, I understand that. It was easier to rename and not confuse
> something.
>
> Could you please rename them during commit?
> Have I to send new patch version?
No need to send another patch. TBH, I wasn't intending to change it at
all - this was just supposed to be a note - but I can if you'd prefer.
~Andrew
|
