Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Fri, 2023-03-03 at 10:53 +0000, Andrew Cooper wrote:
> On 03/03/2023 10:42 am, Oleksii wrote:
> > On Fri, 2023-03-03 at 10:33 +0000, Andrew Cooper wrote:
> > > On 03/03/2023 10:24 am, Oleksii Kurochko wrote:
> > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > > 
> > > > diff --git a/xen/arch/riscv/riscv64/head.S
> > > > b/xen/arch/riscv/riscv64/head.S
> > > > index adf5d6c74a..8887f0cbd4 100644
> > > > --- a/xen/arch/riscv/riscv64/head.S
> > > > +++ b/xen/arch/riscv/riscv64/head.S
> > > > @@ -18,6 +19,14 @@ ENTRY(start)
> > > >          li      t0, SSTATUS_FS
> > > >          csrc    CSR_SSTATUS, t0
> > > >  
> > > > +        /* Clear the BSS */
> > > > +        la      t3, __bss_start
> > > > +        la      t4, __bss_end
> > > > +.L_clear_bss:
> > > > +        REG_S   zero, (t3)
> > > > +        add     t3, t3, __SIZEOF_POINTER__
> > > > +        bltu    t3, t4, .L_clear_bss
> > > Using t3/t4 is fine, but it would also have been fine to use
> > > t0/t1.
> > Yeah, I understand that. It was easier to rename and not confuse
> > something.
> > 
> > Could you please rename them during commit?
> > Have I to send new patch version?
> 
> No need to send another patch.  TBH, I wasn't intending to change it
> at
> all - this was just supposed to be a note - but I can if you'd
> prefer.
Feel free to do that.

Thanks.

~ Oleksii