[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/spec-ctrl: Enumerations for DDP controls
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Mar 2023 10:24:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LAlsi9OTOeO3VzzdG9/7M+XJ6zFixM46BZFjiesUaKY=; b=hx42XIVknXj9v1SDRBmaxdAP9/fNcIph/cHsR2/rj8nPGf5PdnNiYlGos6b65SzFdMFOCv5Lz+PuYmrpwzPsSEf0KXPLp3May/lw13yYoEb0QZq2Qw34kdDv8USAUJRriT895vBBiUrM3x6CRwZDqwkp4OETPZloQ0JXotPIbIkoKh+RD2Z7sLsVZ3ia4xEMCR5czEDVRj2joc3VvJRCDBl+K+sHvZiwklSgqK7xYgULIJeW4EVrVq7TNDBhm8v00C/ENAmYuc97dyeJsHkj5bmUoUxWz3v3NcEEs5rQh0iTSv0WChEMvuB72dhS9vXcEALYRGxuzlvRX1GwfFeDRQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=drQoVJnJDZf5PMMmUL9rmvoVh+9fYyPhFd/2wrnfafzWSGZDnIpyTvejkdNBnm7fTVrbO++19DqgnCn5bp0mmJ5fadQN/k2pChUV3u/dXihzZNIZadrcNUPuFfnP8Cf1ugp57AblsgoWzVAqpAutn3YbKdVQGL/Hr974rNSFGkhZKd9ul3vZ1GDnuYMOjfvShHKriD8eTwmePX2O5vH+ietBy+n38UNX699X+uG0in7RHSMammd37f3t1RMKHYZXNpoiEqMbNaZ4uAiCSd4QlMgDKO3WVTa1slz2yvBbleTxKsQ5+eLgH4aJRqtf7uGu9xUi0rGjswpkrQW4Hc2xQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 09:25:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.03.2023 10:21, Jan Beulich wrote:
> On 10.03.2023 17:02, Andrew Cooper wrote:
>> --- a/xen/arch/x86/include/asm/msr-index.h
>> +++ b/xen/arch/x86/include/asm/msr-index.h
>> @@ -41,6 +41,7 @@
>> #define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5)
>> #define SPEC_CTRL_RRSBA_DIS_S (_AC(1, ULL) << 6)
>> #define SPEC_CTRL_PSFD (_AC(1, ULL) << 7)
>> +#define SPEC_CTRL_DDPU_D (_AC(1, ULL) << 8)
>
> The doc calls this DDPD_U - typo, or do you happen to know that the doc has
> it the wrong way round (and is going to be fixed)?
Actually ...
>> --- a/xen/include/public/arch-x86/cpufeatureset.h
>> +++ b/xen/include/public/arch-x86/cpufeatureset.h
>> @@ -295,6 +295,7 @@ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A
>> MSR_SPEC_CTRL.PSFD */
>> XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* MSR_SPEC_CTRL.IPRED_DIS_*
>> */
>> XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /* MSR_SPEC_CTRL.RRSBA_DIS_*
>> */
>> XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S */
>> +XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDPU_U */
... here you have even two 'U' in the comment, when one of them wants to
be 'D'.
Jan
|
