[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/spec-ctrl: Enumerations for DDP controls
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 13 Mar 2023 11:12:31 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wsDL/+1Ci/4hot0VSNWmlW5T3ihkrCF77IzfkGB1Ayk=; b=Q5bvX0f0eqL6FxfUyGO6CMIB7fcge3JQIzY3BYw/oE0uN1DnHZu/+g2lZlUaVHjNSg1kbeFmhv0unv901EXXyNax/dC1TjtsrgxEn8hIlYvVzcaBd04JKarNGDrsNH8/H8iGFxau5TVkqspXu8Mu0ynScyXl+DIefXRlL+8x/0Mg4Pk2txbZjEKM/nA4VTNdwEH+Y/ajExf2N6aj26/Gh/8PxlYaKXhq2vwhwBzZS6jW//QtJVHUeBNbMCbYc0R/30Ju+lvIlS6AOPjwBhIuE4SPHG+fJttM3RlYqW9+I1wn2nQnPVuiTmSgBIXXK6pcZ3ijhE+NI7PhTeALIm16NQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kP4AE7QHC0gUaC/G7FMuMtlzvNxiJOe/NG96T+Ku2++OsMGA/tINZTh9+aSvTNx4od4E7+tfEYHXpud/AjDBgGBdsfcorLnnsksq2et6ll1U3C/Ta7o4WNg5/0ZBChyrD0A5DloBttBb9mJR9RM/YLxfbTfUSzg1TOF3jLb1ARBp3v98Nk1BzAi3iKikcIv+uFTW/lficeJpsuyIciTUePgwpWQ6DQdBpgzM9kBt95X86rUtvc3T8q15ryxMzfQovCtQE2y7oyMM06+e37o70ytliX9nC6qyT6PtRMTltrOxyO95mQaVRMP/H3iiXW9Q+SRWGAjXj9iqyXssD8grWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 13 Mar 2023 11:14:25 +0000
- Ironport-data: A9a23:LGfP0662KTHHGT+saRNzygxRtBXGchMFZxGqfqrLsTDasY5as4F+v mpNXDqAaPvfajOkco90OdiypkNS68PQnIBnHVNpqH83Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPasS5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx M4RCw8XSEq6ivuW/KmZE89mh9UhBZy+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOKF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKT+Xgqacy0DV/wEQcBkAPTQaYhcO5tWuZcu50J 0BN8BQx+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mpZ5piBvKF45nCPTs1oezHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa0owFqxJrVZg EU5pg==
- Ironport-hdrordr: A9a23:HM2IdazejXH1lk5ab9HmKrPxMegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67SdC9qADnhPlICO4qTMqftWjdyRGVxeRZgbcKrAeQeBEWmtQtsJ uINpIOc+EYbmIK8/oSgjPZLz9I+rDunsGVbKXlvg9QpGlRGt5dBmxCe2Km+yNNNW977NYCZf ihDp0tnUvdRZ1bVLXyOpFDNNKz1eHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lMzQi5C2rAr9E nCikjc6r+4u/+25xfA3yuLhq4m1OfJ+59mPoihm8IVIjLjhkKBY5lgYaSLuHQYsfyi81Ejlf jLulMFM95o433cU2mpqV/G2hXm0hwp93j+oGXozEfLkIjcfnYXGsBBjYVWfl/w7Fchhsh11O Zu03iCv5RaIBvclGCljuK4HS1Cpw6Rmz4PgOQTh3tQXc83b6JQl5UW+AdwHI0bFCz3xYg7GK 1FDd3a5txRbVSGBkqp9VVH8ZiJZDAeDx2GSk8Ntoi81CVXpmlwyw8iyMkWjh47heUAYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMUqJSG6XVJ0vCjbokdra8b817OaldNgj150pgq nMV1teqCobZ1/uM8uTx5dGmyq9AVlVZQ6diP222qIJ/4EVHNHQQGm+oREV4oWdSswkc47ms6 3ZAuMQPxfhRVGebbqhkTeOHaW6EkNuI/H9iuxLKm5mnfi7WrECltarBso7d4CdWAoMayfYPk YpegTVCYFp0n2LM0WI9SQ5HUmdNXDCwQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/03/2023 9:24 am, Jan Beulich wrote:
> On 13.03.2023 10:21, Jan Beulich wrote:
>> On 10.03.2023 17:02, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/include/asm/msr-index.h
>>> +++ b/xen/arch/x86/include/asm/msr-index.h
>>> @@ -41,6 +41,7 @@
>>> #define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5)
>>> #define SPEC_CTRL_RRSBA_DIS_S (_AC(1, ULL) << 6)
>>> #define SPEC_CTRL_PSFD (_AC(1, ULL) << 7)
>>> +#define SPEC_CTRL_DDPU_D (_AC(1, ULL) << 8)
>> The doc calls this DDPD_U - typo, or do you happen to know that the doc has
>> it the wrong way round (and is going to be fixed)?
> Actually ...
>
>>> --- a/xen/include/public/arch-x86/cpufeatureset.h
>>> +++ b/xen/include/public/arch-x86/cpufeatureset.h
>>> @@ -295,6 +295,7 @@ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A
>>> MSR_SPEC_CTRL.PSFD */
>>> XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /*
>>> MSR_SPEC_CTRL.IPRED_DIS_* */
>>> XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /*
>>> MSR_SPEC_CTRL.RRSBA_DIS_* */
>>> XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S
>>> */
>>> +XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDPU_U */
> ... here you have even two 'U' in the comment, when one of them wants to
> be 'D'.
Yeah, I've messed this up. It's supposed to be consistent with the
public document (which I ought to have checked was consistent with the
non-public reference that I was using...)
I'll fix up and repost.
~Andrew
|
