[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/7] tools: Use -s for python shebangs


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 14 Mar 2023 14:50:48 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3w8y3VNTLsGYFjj3xShndVYOtOkKbrGK4R6HdTC3+hY=; b=XSnHVVwJ7elZADZpZmwMhZaDzw04Z7LdBI0DF2NBJPloCQP8x5Yjg/Oj//KzcpxYJdDioyWdOUez8xe5ELT6f4pWl7OR6wsEQDvK8gCP2yoXxUi/CaZ6TF2vtelut5AafpeGvLatj+O6mzNmGHLc+8Bgxg3VN2dIS21cShhHw/PG5IS0aJaJwwad/hYi47crRRYiCOQCzDap/jkUAv+cIeahgL8gdMQVBfRVfFcNYuYI8jS6aaP/wswGaf3S1eXS0DDvtOLc2hUqnmuOvi2XoOMAXedNolg4psGK5K1bG3LilHK+Jy0QIbNOz3Y+Nyb4cHVG9h+FQiClaj9bxtN3+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmseAkAPUKBvEdvvNqbnE0jv2pIlOWHWCH+XgyL9r0fSyzrOmGCSj9eyx9HiZKIm7EnvsECuOMvsXEfTXFS59zzm0hKhuJ2U0eH/4JzleTB2vbv38UZ5Cn/MRhdwfK0LjtDeqaBDRbhyxQvS/PRpiydBg51GWw1ss6hc6ej9F7PG4cGWxprDoJVKVL+9V3/tEWDnakfODwHiGMtWOIc7g4Vl5BkE+CTnqEtj1I4geSHQ0endLRKQmtpgZpiwjmiFykTlPsqQitKy6dOuCRx7ifw70cqJFg6Ax3uUJ8wLOhDy0tGrd/Yx6PYaAJDQa2ZkpAqBKVci6e95c3mTMcup6g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Mar 2023 14:51:13 +0000
  • Ironport-data: A9a23:LMdfxanv/gVE6al9BAArXmbo5gyyJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWXTyCOveNN2SkctFyYIiy8xkPupOGy4VmQARvqHg2EyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgQ5QOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cIzJAEcVyu9vu7137fmVutBgts6MuC+aevzulk4pd3YJdAPZMmZBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkV03iee2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOXnp6412wb7Kmo7ChQmewPl/euDmkORZtRCK lIKvTgzov1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebSMu/ k+EmZXuHzMHmLicU3eU7LqXhTK0JykOLGUGaDMETA0K+N3qqsc4iRenczp4OKu8j9mwFTSux TmP9XI6n+9K0pVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLpm4U2l/MBVfNgwIQ==
  • Ironport-hdrordr: A9a23:NFp1uaBXYuGmPXPlHel+55DYdb4zR+YMi2TDtnoBMyC9F/byqy nAppomPHPP5Qr5G0tBpTn4AtjnfZqEz+8N3WBzB9aftWvdyRCVxehZhOOJ/9SKIULDH4BmuZ uIPJIOa+HYPBxWgcP7/wWiA78bsby6GMfBv5an857Bd3APV0gl1XYfNi+LVkl7XhNPC5YaGI r03Lskmwad
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/03/2023 2:15 pm, Andrew Cooper wrote:
> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> index 29ad0513212f..04b3995cc0f6 100644
> --- a/tools/pygrub/Makefile
> +++ b/tools/pygrub/Makefile
> @@ -7,7 +7,7 @@ PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
>  INSTALL_LOG = build/installed_files.txt
>  
>  setup.py = CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" 
> LDFLAGS="$(PY_LDFLAGS)" \
> -           $(PYTHON) setup.py
> +           $(PYTHON) setup.py --executable="$(PYTHON_PATH) -s"

/sigh

CI has gone a wall of red to this.  Apparently --executable is only
known by setuputils, not distutils.

Which is a problem because it means the main pygrub executable won't get
a corrected shebang, as it doesn't pass through install-wrap.

In the short term, I could fix that by moving the main pygrub binary out
of setup.py and do it manually.  Thoughts?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.