[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] tools: Use -s for python shebangs
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 16 Mar 2023 12:15:04 +0000
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Bernhard Kaindl <bernhard.kaindl@xxxxxxxxxx>
- Delivery-date: Thu, 16 Mar 2023 12:15:55 +0000
- Ironport-data: A9a23:iUe/NqJaJm4UKkiYFE+R+pUlxSXFcZb7ZxGr2PjKsXjdYENS0jQDy GEaWDvTbv2NMTTzeotzat/i9kkGuZeBx9I1TgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA5QVgPa4jUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5uJD0S/ vI0Lws0UTeNi9mZm6+dRNZj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHZ4IxBzG+ j6uE2LRPB0nEIOizGO5qVGOl9TsnXPhfLI4PejtnhJtqALKnTFCYPEMbnO+qOO8g1SzWPpeL VIV4SskqaUu9E2tQcL5Vhf+q3mB1jYVQ9dKGvc2wB2MwKHTpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRutPQAFIGlEYjULJTbp+PG6/tt11EiWCI8+Tujs1Iad9SzML y6itQ1i274dockw7pqc81z8rGmxgJb2QVtgjunIZV6N4gR8bY+jQoWn71nH8PpNRLqkokm9U GsswJbHsr1XZX2ZvGnUGbhWQun1jxqQGGeE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O RSD0e+9CXI6AZdLUUOVS9jsYyjJ5fK6fTgAahwzRosmX3SJXFXblByCnGbJt4wXrGAikLskJ bCQetu2AHARBMxPlWTpF7ZFjOJyl31jmws/oKwXKDz2uYdymVbPEetVWLdwRrlRAFy4TPX9r I8EapriJ+R3W+zieCjHmbMuwaQxBSFjX/je8pUHHtNv1yI6QAnN/deNm+J+E2Gk9owJ/tr1E oaVBxIClAam1SacQehIA1g6AI7SsV9EhSpTFUQR0ZyAhyRLjVqHhEvHS6YKQA==
- Ironport-hdrordr: A9a23:Rgcqj6MMZgCFkcBcTsWjsMiBIKoaSvp037BL7SxMoHluGfBw+P rAoB1273HJYVQqOE3I6OrgBEDoexq1n/NICOIqTNSftWfdyQ+VBbAnwYz+wyDxXw3Sn9Qtsp uIqpIOauEY22IK6PrH3A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 14, 2023 at 02:50:48PM +0000, Andrew Cooper wrote:
> On 14/03/2023 2:15 pm, Andrew Cooper wrote:
> > diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> > index 29ad0513212f..04b3995cc0f6 100644
> > --- a/tools/pygrub/Makefile
> > +++ b/tools/pygrub/Makefile
> > @@ -7,7 +7,7 @@ PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
> > INSTALL_LOG = build/installed_files.txt
> >
> > setup.py = CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)"
> > LDFLAGS="$(PY_LDFLAGS)" \
> > - $(PYTHON) setup.py
> > + $(PYTHON) setup.py --executable="$(PYTHON_PATH) -s"
>
> /sigh
>
> CI has gone a wall of red to this. Apparently --executable is only
> known by setuputils, not distutils.
>
> Which is a problem because it means the main pygrub executable won't get
> a corrected shebang, as it doesn't pass through install-wrap.
>
> In the short term, I could fix that by moving the main pygrub binary out
> of setup.py and do it manually. Thoughts?
Or do the fixing in "setup.py", https://stackoverflow.com/a/17099342 :-)
But that probably more work that necessary.
Doing the binary installation in the Makefile sounds fine.
Thanks,
--
Anthony PERARD
|
