Re: [PATCH] xen/riscv: Fix early_puts() newline handling

[Alistair Francis <alistair23@xxxxxxxxx>]

On Thu, Mar 16, 2023 at 5:03 AM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> OpenSBI already expands \n to \r\n.  Don't repeat the expansion, as it doubles
> the size of the resulting log with every other line being blank.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Alistair Francis <alistair.francis@xxxxxxx>

Alistair

> ---
> CC: Bob Eshleman <bobbyeshleman@xxxxxxxxx>
> CC: Alistair Francis <alistair.francis@xxxxxxx>
> CC: Connor Davis <connojdavis@xxxxxxxxx>
> ---
>  xen/arch/riscv/early_printk.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c
> index b66a11f1bc1a..97a94885773b 100644
> --- a/xen/arch/riscv/early_printk.c
> +++ b/xen/arch/riscv/early_printk.c
> @@ -16,8 +16,6 @@ void early_puts(const char *s, size_t nr)
>  {
>      while ( nr-- > 0 )
>      {
> -        if ( *s == '\n' )
> -            sbi_console_putchar('\r');
>          sbi_console_putchar(*s);
>          s++;
>      }
> --
> 2.30.2
>
>