[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] x86/HVM: support emulated UMIP


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 17 Mar 2023 17:09:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QxVYceOxp4b7SJlHcui+eVM5fXAkbBRqOIRY0fvjGuA=; b=bVIiU8ecYVHVGvHkysW46zarBABTJwKrVmQqzD3GfHTvYlyvHCJYvLw50MvSQpaJvsHTcBxySAUwQNO7b9XfEGDuJEeGGfWytX6C5JeuhQ30xKyLDE2ryzAullL4cj2asPa38R0CdY8LHjSWm86kwClj1tZko+bhvYV2ZibqpPl3MCMR4RUruDU5NR0TUGoT99dqbIdRZXF55W/cbWA2Cb/JVwq/L0xj+HSaasC4tz4m0xDL5ii46ivv/hAdZYnjuyDynuu+ViUUP6TGOz9TX+NqVXo7HyRfbKYWir8ZIijru0h1Lq6LH5HNenIvhdLZdGiM237/Xz9Bi+rrM8JXxg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j74Py65T+Ef+HJd17j025ed/EfaxizPfmASdw4nr1L7tRa1BErXrYhg+/afB5S9f5olKB1kC5frJZCtuQNsgNkKgndSIOQShvf/KwD9xmgTj6DU8W8AfY5QlksP9gk+YSNius/2MHBi2J7HcnRdzF37w2hUBWWBq516moD0YFG4Uujy3kpgGYcTg2PJlhNFieJPf0gC11FMfBGynxdKQ2DHF+VirGM0O4Eb8jG8ApcM91JvFoGDVOy7JmnhjCvB9e13wXLXvpCAvRQn6T7GxT+5/rTybJyLsm5PHmF0uVWYbtDSo/NQuE9VmTzrQls9nd1PRk61i++CDKZthomc0gg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
  • Delivery-date: Fri, 17 Mar 2023 16:09:46 +0000
  • Ironport-data: A9a23:DyklaKOQauIRplTvrR1xlsFynXyQoLVcMsEvi/4bfWQNrUoigTBRz GUZXmGAb/3ZMGD3f9gjaY3koEoGu8TRydFmSQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tD5wNmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ulxLkts0 NsBEx9ObEuKoMSL246FVuY506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCCpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+tqyr32bafwHqrMG4UPJac6tVEpgeB/WIKJxoaDnWpotifhUHrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+8rj6sOC5TMW4LYwcFSxcI55/op4RbphDSSJBlGa28jNzwEBnxx SyHqG41gLB7sCIQ/6Cy/FSChi32oJHMF1Yx/l+OBjPj6R5lbom4YYDu8ULc8ftLMIeeSB+Go WQAnM+dqusJCPlhiRCwfQnEJ5nxj97tDdEWqQQH80UJn9h1x0OeQA==
  • Ironport-hdrordr: A9a23:wi/TMKjaLnK9Gy04s7HjjEAk53BQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Mar 17, 2023 at 04:01:59PM +0100, Jan Beulich wrote:
> On 17.03.2023 15:29, Roger Pau Monné wrote:
> > On Thu, Apr 15, 2021 at 11:47:42AM +0200, Jan Beulich wrote:
> >> There are three noteworthy drawbacks:
> >> 1) The intercepts we need to enable here are CPL-independent, i.e. we
> >>    now have to emulate certain instructions for ring 0.
> >> 2) On VMX there's no intercept for SMSW, so the emulation isn't really
> >>    complete there.
> > 
> > Then I'm afraid we can't set the bit in the max CPUID policy.  What
> > about domains being migrated from a host that has UMIP to an Intel
> > host where UMIP is emulated?  They would see a change in behavior in
> > SMSW, and the behavior won't match the ISA anymore.
> 
> Right, but that's the price to pay if we want such emulation (which back
> at the time did look at least desirable, because the other affected insns
> are more important to deal with). Not setting the bit in the max policy
> is as good as not having emulation on VMX at all then.

It would need some kind of justification at least on why it's deemed
worth exposing in the max policy (and thus made available to incoming
guests) even when not compliant to the specification.

Could the non-intercaption of CR0 reads and thus no #GP on SMSW on
Intel lead to software malfunctioning as a result?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.