[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ns16550: correct name/value pair parsing for PCI port/bridge


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 29 Mar 2023 09:25:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ioLo9+0X+GQ5YQ1JVPore/ZKCbNiW29s/t3/+NymwGQ=; b=ct2gDBa73+CKnM5l6+D8RTkobqtwNsecasNNYVUQc2aGsAb7oq/NjwGjSq6oBMxEpKzcUy//EChKnZAfs3McR+8ptSIKso5jvDgMrB+6eUR/VRW7e/TVfpEL/lieLi1C4NjWOF24rbn2NZzkktUurHaTgbuInBOXzPOnhBDI75D6F4daI0T9v6y/+I5KWpUJzQTP8VOsef+GU81fuTruXtmHimlCjf7kP7GWvcYyG+mrPVqJfTrZSkz7t5Z4GSHFdkQ89WznD07cV3BmQvGsvj484CX25+KhSzWN6jnRZWN22B3tKawlMHZv6SHGttLkCcpkMfWnCEyKRRr2uIt6BA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mjttkJa2YOFuI9xAFrHzd8SERt3Tv+fsgNBZJ+gwgbqaug+URl82fECyzOuyIwvXW7abvpZkCMVWPh//xBoOzP7eS1YYMjvgMkiJu06LwEJf5d59yG9WbgoZVLuoipr1EcxjuTwGoIyP/WOJjSWtH+vFiM80wnOvmHkkDPr0/88z3HGtQuAvIdkGUuuewRKFbvRYIqphU+eVbJScEGJDVyzFHIoHABJuBhJ5TzDNvmmwQN30rFhTCEz3NZgZPKRTnxoDGu8G6nXEK8IWV04Uh3tmrozQeXyJIHxNd+HKHjTeI4rLnqrkuxYtOGPH1tNP/GzkT+EfWoNJYre2czP3EQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 29 Mar 2023 07:25:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29.03.2023 09:19, Andrew Cooper wrote:
> On 29/03/2023 7:50 am, Jan Beulich wrote:
>> First of all these were inverted: "bridge=" caused the port coordinates
>> to be established, while "port=" controlled the bridge coordinates. And
>> then the error messages being identical also wasn't helpful. While
>> correcting this also move both case blocks close together.
>>
>> Fixes: 97fd49a7e074 ("ns16550: add support for UART parameters to be 
>> specifed with name-value pairs")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks; I'll assume you don't mind if I correct the domain name spelling
while applying the tag.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.