[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/8] x86emul: a few small steps towards disintegration
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 30 Mar 2023 17:14:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KeHIt9ihxT5cOnOpElgxGNfRw0+SH2AhN4CuIc2+a9o=; b=FihD1AvaEgBWhpyFNYMu+ZllrzJi265JNzQJ77HyS2mpjs0dgGkwHppvEldkPrcEclZUcmPk/0NDc0TbGNhWQq6H76zzuRLvSsL9T7zSby+fYbN5Lvnb3jhAMspMF3nJ5DReOZmeVyR6bTPgqN/ePDA6DguM2qaLqTtYFPkqHYc2KX0CmF93/Ze4LFDxX2K4wDr5E913S3bb3VTs1hOvjk396QOniifM/4rHpeI9SyotXlewlmsub7324BZmaGhSoePJ0yL6SPmGhcU2wiCbU2KtWwt0vJufeDqCkOVNudMXLcL0FfYbcA0I/ZDICSTzOAJd5QvnheqynLnMIDEqeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHlzn2ypmvv3TFAVUBR7caRELki3z+DAsGE/aWUeBejWhpAemQzoW5LoZF+nkspzgsvWwodticRJErzIKlL5BTwf9gux8Ip4bJsFWOfiGWP4kfo48LSDLh8eD2x9fdWzquHREKijn7/CjAcXB3W6zt7Exg2rHVHz4lpqA/LhFqV+n9bmDp8cE97SwSdqBtXlFU+J1ek0V9ZPBpwoAz3Q5eQOb/HeE+bPq6mYPGuZdFCwaFtVg6SqILk7x0fRwSWch17r4zzTe3iKkeEbMGWv4YzyhYcHPwMzD20wUV3w9ER0CVfbU27NAAOIzJAQLZ5KFUGVqCiDZPpnCgu7ozxPtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 30 Mar 2023 15:14:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.03.2023 16:27, Roger Pau Monné wrote:
> On Thu, Mar 30, 2023 at 01:40:43PM +0200, Jan Beulich wrote:
>> On 30.03.2023 11:54, Roger Pau Monné wrote:
>>> On Thu, Mar 30, 2023 at 09:53:23AM +0200, Jan Beulich wrote:
>>>> On 29.03.2023 16:17, Roger Pau Monné wrote:
>>> Patch 8 I'm unsure, I guess it should be up to the user to decide
>>> whether to use -Os or some other optimization?
>>>
>>> I expect introspection users likely care way more about the speed
>>> rather than the size of the generated x86 emulator code?
>>
>> Perhaps. But do we want to introduce another Kconfig control just
>> for that? And wouldn't there likely be other performance concerns,
>> if performance really mattered in the introspection case?
>
> I don't really have a strong opinion on the usage of -Os or not. It's
> likely fine as long as we also stay consistent with the flag we use
> when building the test harness and the fuzzer, just in case.
While they might be built with different compilers (and hence things can't
be compared directly anyway), I can certainly make those two use -Os as
well.
Jan
|
