[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/vPIT: re-order functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 1 Jun 2023 13:50:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xGzawwoC9UY5qFe214NgHVjE2gGttr1uXclxyjAc6rU=; b=KMXRQPqP6RTlnrvgnx/5iV7oeIbkKaJmbb9GC9Xh9K+AzF5zdDXemB832cYFY+2FD5hq4ABsQDjRnhQcASbu078RL2ZRnGZLfxDyQC4Z6JsxDZ4pnF4cBOK4Gv33QOPBMLoQIiwb5GZwPA4VGbt03zwXyptUotQVXSJQZoHS4iHh37eWfpzACLfUjNilU8mOSSUYrrGFyZ8fHTPEUj10cvaINy1UTObQaA+0Mldw0+LjzJ5RSB94zo9OR9DsoYW1MQ7xHERma7n0jYr21oZ6ubGu1sBtyEEQzIi7pU4Sd940s8ZcmvwtiVhl2dFYLKvis1vP3+dG+4gAIe0dfpJE2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYulKnFJaXQ9AokybLzD+MUTal5zhcKOIz7xbSAzCdr+s28EiltV3MSiAPoyt9LK6k5w5nB3stbeyvt45KJsQdi3c2ZVrSVhWahX0ONP0xTkcTEUJIQ2rnc+L8QFKJDAV6QSJOkcfx5Sawg8WQJesCyqmmJO3QTuxmwJre8HPiL8UL2jULoT70Ks8pC+nIzOa/ompz9gEIAql5KlWFdBZ0KQnZIBm29oxIQU4ZmiYOwM90dOHCTCkw2b9So/ghKnlQJQ0wajyUTBTTgUoaqAjev4CpBrXM+dpgJ/uYll4HeaP2j6xp5TqQJQI40z9RM2tYZXaC2w8V8hWVSLE3jhug==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 01 Jun 2023 11:50:56 +0000
- Ironport-data: A9a23:46KQPKpnNHV6mmGMx+izx1jvV5BeBmI+ZBIvgKrLsJaIsI4StFCzt garIBmHbPqIZzT1KI9/bYvl8UhTvZ+GydIyTQtspSwwHitApJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GtwUmAWP6gR5weAzyBNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD8sagKGhNuO+fWmE7g8o/QBFcfCOoxK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKFEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTAdtKSeHhp6466LGV7lEYTxpRegO4mOCgzWygQOMHE WYk3BN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zvpd81hxeWFtJ7Svft3pvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzt56s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:RKGPNKyCB5U+F5OlceE9KrPxS+gkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRZxRBf7LdUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrXAgWVxRAXVhJI2PMH/X LemwL0y62/u7XjoyWsmlP73tBzop/M29FDDMuDhow8LSjtsB+hYMBMSqCPpzc8pcCo8RIPnM PXqxktEsxv4zf6f32zozHqxw78uQxeoUPK+Bu9uz/OsMb5TDU1B45ogp9YSALQ7w4FsMtn2K xG8mqFv94PZCmw1xjV1pztbVVHh0C0qX0tnao6iGFea5IXbPt0oZYE9E1YPZ8cFGbR6ZwhEs NpEMbAjcwmOW+yXjT8hC1C0dasVnM8ElOvRVUDgNWc13xskHVw3yIjtbgit0ZF0Kh4Z4hP5u zCPKgtvqpJVNUqYaV0A/pEaderC0TWKCi8cV66EBDCLuUqKnjNo5n47PEe/+exYqEFy5M0hd DoTE5Yj2gvYEjjYPf+kqGjyiq9A1lVYA6diP23v/NCy/jBrfvQQGK+oWkV4oudS651OLyeZx 6xUKgmdsMLY1GeXrqh5DeOK6W6GUNuLvH9hexLKm5mgvi7XbEC5darBsr7Ff7KLQsOfF/ZLz 8qYAXTTf8wnHxDHEWIzCTsZw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote:
> On 01.06.2023 11:17, Roger Pau Monné wrote:
> > On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote:
> >> To avoid the need for a forward declaration of pit_load_count() in a
> >> subsequent change, move it earlier in the file (along with its helper
> >> callback).
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Thanks.
>
> > Just a couple of nits, which you might also noticed but decided to not
> > fix given this is just code movement.
>
> Indeed, I meant this to be pure code movement. Nevertheless I'd be happy
> to take care of style issues, if that's deemed okay in a "pure code
> movement" patch. However, ...
It's just small style issues, so it would be OK for me.
> >> --- a/xen/arch/x86/emul-i8254.c
> >> +++ b/xen/arch/x86/emul-i8254.c
> >> @@ -87,6 +87,57 @@ static int pit_get_count(PITState *pit,
> >> return counter;
> >> }
> >>
> >> +static void cf_check pit_time_fired(struct vcpu *v, void *priv)
> >
> > Seems like v could be constified?
>
> ... the function being used as a callback, I doubt adding const would
> be possible. Otoh ...
Oh, I see.
> >> +{
> >> + uint64_t *count_load_time = priv;
>
> ... there's a blank line missing here, if I was to go for style
> adjustments.
Sure.
Thanks, Roger.
|
