[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/vPIT: re-order functions
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 1 Jun 2023 16:06:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cag0FQovFb8An+lX5p2ZebBddZmR0g8ibj2elL7Tss8=; b=jU3hkya6qVVY8aKfykcWlhlXo/1fOGZVluRi8tkBj/epVkxixPSWbfWD/wqEW2pH7Aq5nexXPdQgoeR0utpWnuZ6oQtMwsY4RAJcL7kfP03tV1l0wtAq5MHZjN7iFTNmaNxe645CGhcHE4r4Ge2lprX5+3ttF2xzlXrvbTjxZFzqFTxxMwAp8DkAlWQYjNJXtuM4GsfP4TcCcAWIf80z5V9/FwzdCacbPGSdt9f3AK06OgalVyGEgKK91D2TuXQDdh5khle9cNnTK0mFG9FD4xjnDOSL0t4gm+BP+3enlzkZqjfA8G3snWOry/rg/JCPCn11D8o/MtGqPl80SHfvHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPyib4fYgA8fSBaimWVBuU9a8MTxAtDdqHTpmIElQiFL2OWJF93AJsRumpU76qt9lchu28J40XvHpYuNo2xMX5CJ48CuTN1OHVvh4MC+3ZjJUHzgdGglqf8qyL9WhhYWU5YePAVvvBn7oL6ofGP0opoko3HafQekyzbYNRn0gzp6Ef30+fIC4vbplpJAvY7OobC8kEW9v9DjL8QeNoIhTBaapuemwIGgvOXSSoV/gxe0Dhrt7Rdm+Ak+b1u+xKurIqgNJYU+DmeQh9KmKBG0VUi9wGOrCpCIf8+GQF203Ctv1QbHlVVYhrqBUeNyhWBPgJ+gCviLpBlwEyt8CRAlCw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 01 Jun 2023 14:07:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.06.2023 13:50, Roger Pau Monné wrote:
> On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote:
>> On 01.06.2023 11:17, Roger Pau Monné wrote:
>>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote:
>>>> To avoid the need for a forward declaration of pit_load_count() in a
>>>> subsequent change, move it earlier in the file (along with its helper
>>>> callback).
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>
>> Thanks.
>>
>>> Just a couple of nits, which you might also noticed but decided to not
>>> fix given this is just code movement.
>>
>> Indeed, I meant this to be pure code movement. Nevertheless I'd be happy
>> to take care of style issues, if that's deemed okay in a "pure code
>> movement" patch. However, ...
>
> It's just small style issues, so it would be OK for me.
So I've done the obvious ones. There's a further signed/unsigned issue
which isn't quite as clear whether to take care of "on the fly": The
function's 2nd and 3rd parameters both ought to be unsigned, yet
throughout the full file the same issue exists many more times. So I
guess I'll leave those untouched for now.
Jan
|
