[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/vPIT: re-order functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 6 Jun 2023 11:35:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=74QDny3FJUbcux5HKD1saecs2YtDmkfbXZauTFG4qyo=; b=a63LMQhVYWt8lfrdwo4dDSIQilZxX6VV3HyfOESBpS6AvZYcqv5ZyKBtvCitSccaX15hWXYo/C2IQITV16dl7GopgO8FD2M2xOsRQugtbe8QKJxhs+zl/gmqr/yvcpOkhTiBM58e9u5TU/x5i53u3eqaYyJPeyIKbS4Rb4mHSW1kKDGLStETHD1RWLS7zIIz4U7ZXlM/XBcvFv0mlWcMo+0WmyCjCUA19Esx70Qtw7szqbQpM3rXGLm4IL/R8yxUkBINW8MsUNHY0IBzDFQJPtnegSRPmLzJfpOEjveNo/Dx/QJUQsf04Cs5qh/bv+M5ZL/X5SymJdvOd6ub4IWJ3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gy8e+Lnm0TFnD1t4jvcj4elntn0XNClVkyBQNd3nIy6AXAM9VKzMFfpuL2Fi9V37qOgv+ATQ8De2208oe/iNksAuDdAwimbtxCKeCmnj/vJSNX3vPxbIIlbhKaV5mqnLXweVyhSiSDHGo3f+KUSwpxOz2tGk/Cd522z6JVIe29xp983Vx7W42JJrfXPgX/e7SwuVNfRgI/KTvZqpmc7rGLN5oVy5vJsypywoMZYVB+ZUuDQobz2PlnTCeEiE0FiFcAudzM9oEMyjJTlObpWgwH+0RQ2i5Kszl5xktwdzEXxqzawcQt31xUs2Rrna+6npNmUhTAlBt2E7aM1vzzqaTw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 06 Jun 2023 09:35:44 +0000
- Ironport-data: A9a23:mHut6qJ8SIGdPopGFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENShTRVz zdKDWuCbquONmqnet8iOoy0oRgHv8XWmtEySAZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4ARgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5oIkpP5 8ESFgonVQC7gt2r2ZeqTLFj05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv13LaSw3mmBOr+EpWA+NVD31ij+VAvKxMWclq0nPaJp2GHDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHbihdSwIAuoDnuNtq0U6JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNTNi1CAgbQD0ct9EQ==
- Ironport-hdrordr: A9a23:UT9ARqE5lPvwCnzBpLqEMceALOsnbusQ8zAXPiFKJSC9F/byqy nAppsmPGDP5gr5NEtApTmrAsm9qArnhP1ICNAqTNWftWrdyQ6Vxf9ZnO/fKmbbakrDH4dmvM 9dms5FebvN5DNB4PoSjjPTLz7VquP3iZxA/d2ut0uExmpRGtpdB40TMHfgLqXOLzM2eKYEKA ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jun 01, 2023 at 04:06:53PM +0200, Jan Beulich wrote:
> On 01.06.2023 13:50, Roger Pau Monné wrote:
> > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote:
> >> On 01.06.2023 11:17, Roger Pau Monné wrote:
> >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote:
> >>>> To avoid the need for a forward declaration of pit_load_count() in a
> >>>> subsequent change, move it earlier in the file (along with its helper
> >>>> callback).
> >>>>
> >>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >>>
> >>> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >>
> >> Thanks.
> >>
> >>> Just a couple of nits, which you might also noticed but decided to not
> >>> fix given this is just code movement.
> >>
> >> Indeed, I meant this to be pure code movement. Nevertheless I'd be happy
> >> to take care of style issues, if that's deemed okay in a "pure code
> >> movement" patch. However, ...
> >
> > It's just small style issues, so it would be OK for me.
>
> So I've done the obvious ones. There's a further signed/unsigned issue
> which isn't quite as clear whether to take care of "on the fly": The
> function's 2nd and 3rd parameters both ought to be unsigned, yet
> throughout the full file the same issue exists many more times. So I
> guess I'll leave those untouched for now.
No strong opinion regarding those, I'm fine if you want to adjust also
to unsigned.
Thanks, Roger.
|
