[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 4/4] xen/arm: pl011: Add SBSA UART device-tree support


  • To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Tue, 13 Jun 2023 03:00:02 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dp2enHslGluDBXbeRlwPZHuJfKFakVlzMhWMvVo29Ts=; b=eSYme50VfGMwWnd/XmxOMErnhdj48FpCIVf799MvuaC/7r6GPE5tu3hg63qN6j8zWWc7nZ3CuqVxIR1jBJBF+qerVG9teOI8zihuX0OywY6dTirlaravyq2uIQub6+AawByjNzaEuOzOOBPsw7ClUU8wcICwJRU2SgYCC2bNNnxZ8g7cxA5vz9gkMxdl65dPNsOwSkUVZwJbQlKElJLGT9avap3gqjPU6MuTPrMq4wjsXxxZuUESaA2xI/TQmENyY+6wtRvGYNCyhNrcBUJVXed9+c1XgIkoj9VMeO47CA5ate0/ri0jZrtMPVqO96+IYLEwnl4jzqT/SJSMLC3xnA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NdBEbgI+bnKNw/ISep6U5d9urdaKyzSMLVhyGFiR67+pq2rPJEi/S62ndtOn29P4wn606X77Z1RD1xhP/mBvmJFSk7qrEpWAq/9huaWlSe9FN+BRmmhoDZq6OvSXk0r4vuopTyk4wCAu+PCc651FSk8qjURMTR+u5VCRP8KBNpELdvJerqMGm4FHdcHG+E0fldfE1Fn+lNEWOGHQUZOI9PIeB3TfBcedw/YmWmn6mP6KOk/vuIE3HyXRnG/dUSbxi/2Gw11geL/+1d16cbVLk4MRGXDXEHZr6yjjEQSBGvw21Mdw0A9EaJgmkfWXstIIwdsMCk/4N0giQabza0Jf0A==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 13 Jun 2023 03:00:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZmSJnhkSZmjH+UUWfOrt3uB3WRK+IAYEg
  • Thread-topic: [PATCH 4/4] xen/arm: pl011: Add SBSA UART device-tree support

Hi Michal,

> -----Original Message-----
> Subject: [PATCH 4/4] xen/arm: pl011: Add SBSA UART device-tree support
> 
> We already have all the bits necessary in PL011 driver to support SBSA
> UART thanks to commit 032ea8c736d10f02672863c6e369338f948f7ed8 that
> enabled it for ACPI. Plumb in the remaining part for device-tree boot:
>  - add arm,sbsa-uart compatible to pl011_dt_match (no need for a separate
>    struct and DT_DEVICE_START as SBSA is a subset of PL011),
>  - from pl011_dt_uart_init(), check for SBSA UART compatible to determine
>    the UART type in use.
> 
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>

I've also tested this patch on top of today's staging on FVP arm32 and arm64
and confirm this patch will not break existing functionality. So:

Tested-by: Henry Wang <Henry.Wang@xxxxxxx>

Kind regards,
Henry



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.