[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/5] x86: make parameter names of function declarations consistent
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 6 Jul 2023 08:43:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3bagEtTKs5q13dVLsVFlOthdrN3/s/CIu16GN5UDm2k=; b=amBcjYuPhao2LNGanEHyVaKciSJv9zJd/AqU6Ims75/5KGuCgZgfABdeMSxQqOGKkC992nKzJqd1p2L0DyZxtdTcTw+mlvjiroHJ95kx3vQY9uzT6FQpZH7r8uO6UN8AIscwrQ5bzmAcqwMpQn9OFw27Q5KyI77QxEJ9f548ou+/YcHhZEO5sRZO7IIJgXnV6CXaOrvctWMhQv+cxup5nc60pw2xOku0z1kfJ4Iqx14yNkTBtVCI45CiHwbNdSF2I5RaRz34PvN9o5z4iv7jqR1gn9lxPy+L+1ZQLQuTrxkiGLd22woDkCRMe0zxiyxh7vJ/hrF092hQ2b7NRuJ77g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f7Vs6VFmHkUSNlwrB/oCrT1pkAV4hxSxPBd1OZtbA2Ci2iN6aLB1HQ4TIC8EGESw+SkV8KJL8zUFn2Ru3/p55ZYY1AXsAUZ6VWnQ4J7bWvwTQ5SnbvAAcI2d/pbo/P0XSR0+KRUbYWW9ejuZqqHWCZPe27Hrrhv7CTfk2RkvW2GrFbzGx1z36o90/Ba6rreGPMm4oYxhaob+Tj0u5TU4C5gYTLsicpd29+uruQo66CQE/apFQK5v++aUCz5/ag97I3E496EhDjZ4tqY14NbtSUYCOQFvNg1CpwtFlx6OFsYSG/w6Uqr4jLOOcf5/AQhO/+fDP3dyuYlOEV4cckTtRw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 06 Jul 2023 06:43:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2023 00:51, Stefano Stabellini wrote:
> On Tue, 4 Jul 2023, Jan Beulich wrote:
>> On 29.06.2023 17:55, Federico Serafini wrote:
>>> --- a/xen/arch/x86/cpu/mcheck/mce.h
>>> +++ b/xen/arch/x86/cpu/mcheck/mce.h
>>> @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector;
>>> extern bool lmce_support;
>>>
>>> /* Init functions */
>>> -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c);
>>> +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci);
>>
>> Supported even by ...
>>
>>> enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp);
>>
>> ... immediate context, c is the name we use for parameters of this type.
>> You want to change the definition in such cases instead of the
>> declaration.
>>
>> I also think this patch could do with splitting, not the least to
>> reduce the Cc list(s) needed.
>
> This is a very large patch but it is entirely mechanical (good!)
>
> How would you see it split? By individual files (too many in my
> opinion), or maybe by directory? By directory it would be something
> like:
>
> xen/arch/x86/cpu/mcheck
> xen/arch/x86/hvm
> xen/arch/x86/include/asm
As for the other patch and as mentioned in the earlier replay: By
maintainership area, such that we don't need to accumulate a dozen
of acks (easy to miss one) in order for the patch to go in. As much
as the patch is mechanical, it ought to be largely mechanical to
split the patch at maintainership boundaries.
Jan
|
