[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/5] x86: make parameter names of function declarations consistent
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 6 Jul 2023 08:44:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xvTXt4pOUkcAXx8fS3hBkQbH2/Hl9K9RB7E6QAy7dDI=; b=NNz8LKyqLwXoXuAYbtqvQewu0A5huDxkp5mQ9nl8kMDNeW4PEHCWdbskVXu/IFq4mit2wJzNgAwAqjaxQ/FdCH5anOOjbDK4dRRu1dm4njKroDjiDvkwMf4L8r/s+zNepkFGsaTENgLUq3Mus2el+Mym+SLt9r0m7hOoIkrmuGdHi34d9BZugnMQE/88hxxeY/Kfoc2lxMBFEAPtqf1miwSSQIOqSiLg0n4h4TsAY6P2+A+yN41vgkoKfvpPj8DbOIFt9IuC+QBl41qx5TT7ish8BX3HEXpNhoiOqDAG1cpEO/3UgLdiJ5scpC4ODAG3dwkDLm65rAaGGfx2WVm0zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdjhvDArecvF9rvdUcaBCxtJV9GlAZ1QMKblbnHCfEW+X+xOH132E7YV7PGsWp0M3JNOVdmZaXInXyU1/WHTFW+gHNY9qDoj6Ki+t4mwJ+2EuVHHMW2eHfsimIH8y6OdRbT8xl+obLLkYn2jw7YmLLh9tGZd5cOOrs+W2Z49s7i7vT6KXi7B+4Rpqfn8AjGtcmog9bGK4vZH5Vw+jdP7AIVDD8n51XDIRcAFGmR6Ygk4hKA/donISgGEOJENglbjtO7smatHDe06zyzrGGjASVCvtxzKjDI5fI+on+kCeDtzKYGMvzF2Pnf1TugAxosPv7jt1HfzTb38KSEcO6/05w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 06 Jul 2023 06:44:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2023 00:52, Stefano Stabellini wrote:
> On Wed, 5 Jul 2023, Stefano Stabellini wrote:
>> On Tue, 4 Jul 2023, Jan Beulich wrote:
>>> On 29.06.2023 17:55, Federico Serafini wrote:
>>>> --- a/xen/arch/x86/cpu/mcheck/mce.h
>>>> +++ b/xen/arch/x86/cpu/mcheck/mce.h
>>>> @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector;
>>>> extern bool lmce_support;
>>>>
>>>> /* Init functions */
>>>> -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c);
>>>> +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci);
>>>
>>> Supported even by ...
>>>
>>>> enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp);
>>>
>>> ... immediate context, c is the name we use for parameters of this type.
>>> You want to change the definition in such cases instead of the
>>> declaration.
>
> I should add that if we are going to change some functions in the other
> direction then it would be best to move those changes in a separate
> patch to make it easier to review.
+1
Jan
|
