[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] xen: add stubs dir to include path


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 30 Aug 2023 09:30:08 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l+gJe55HryYfZJ82cRPP1SKKKXFnCI+ORJkKyZKTXXU=; b=aPwftY6hY7d5FwcT08acnh1TK82pYv1kSUA9bSHPxSJoorQjS+ZN/+CeX2hTEiyvT8e6jykGPFLScXPJj5HdjStEAEsdFR/AzPHuGSe/iRFmJjEEHawtwfhRMaOYl8vaoegCcYgx23fM3CG4zjZWPBcOTVb81A3WNgxtCvrSx44Mz2JcugSLaqJ2096oTW9wYMJLdLjV8YMjkwRZLIciGgSsUd3WmUfxSHA2ldneOtu/zosimD3y6o0eTHIyn8+mEupS3HtOcHcyoBllKPyvCaqb3A8c6449kM3v1zbDz7Q3tpd/px5sZe7snYkyDzJ+LZgA2yj4qytGdrxX2KqGCA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LumEtST/DJYJFCI87vQcgC959bvjZOZLjPmbA0hVhhZuCIM9aAp5vOJsAjUa750T9N8sut8CIknjz6apXCbjSTP0VygQbsZIBH4+zTJNKiau4KXIfUzjjYaw9lGMjsGJS+ZZg/KbU0m6OvbrGZo6Gn0GnHncOLrIVDMYjZB7y9XIPBd26RaWHvAaF4LmrjITdHMmBtJz2k8B5Pd9aLTMUsonJndkJQYTlYINhBRwEfJruzyGlA6dxJ21Ws88MZ+kVL5jau4Y98+1KX7/E35Fx+fMy3H1fSANOb4ZnbLZr72v4zHsZ4j1up0pVSZhjYsckgh3lg5yed7HrZAk7uNItw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 30 Aug 2023 07:30:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29.08.2023 16:34, Oleksii Kurochko wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -438,6 +438,7 @@ ifdef building_out_of_srctree
>  endif
>  CFLAGS += -I$(srctree)/include
>  CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include
> +CFLAGS += -I$(srctree)/include/stubs
>  
>  # Note that link order matters!
>  ALL_OBJS-y                := common/built_in.o

I have to admit that I'm not entirely happy with the name. I wonder what
other REST maintainers think. In particular I would consider using
Linux'es "asm-generic" name instead, allowing to cover both stub headers
like the one to be introduced here, but also other kinds of "fallback"
ones.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.