[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen: add stubs dir to include path
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 30 Aug 2023 07:56:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8W1i4kHrGCUzFP6Brnvd8hb9hHlRRrmYYieeDuW17bY=; b=iH9o637QNBUK47ajsAps86Fy2ERLYWdvkGwL/e/reFpkcr2JLgK+o+0X/pxa8Z0ORu9IfDu864AcjOLDlZDmPq3GbwXBIEUPLDtQtdIk/N8X2xNrsVZI3d6zN7lN/Y1cjNEtb0Vpi7Zaq3wE/nhBMHZ1lMltRMNIAGCSlyaJAFVWf/S6SBQ505bpUSKv5J3LfClM5eexDcjZWNohPmtGAb+omUINjErN7qZr0CuJxN3RwX1qP3yExNHhTQCBH78p05C6HL/5+MsKYq/P55Jdc0tpneDypv9y2Zb0wZKAgIJ1o9F04rqBOLD1ZRex3zCdTn30NiGFe8h0vOUD5N9exw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cCk+Ly1Ca0JqH3ap3aL5rhYL69B60LqRwe2090zDBqef2oKLJ6KZ8anvsXgdAXzmuNd8gWAbw1QCwIQHbAStNkyNi6Ik/To4OgzhxUshL2NOa5FiUU8hRCrqvC7fDbZ5ia62LLf0iYn7ZC2kzqpdYObjGgodfQ3Ex6bMz9FfvAQeakwWoZPQp3oVymlAXR1M8Ti3Vrxzr232e3+HNL8tbY25D8O7uT6peKKHtNFuStFJs0RD5H28nzB8HLTy2ciIY2s6m4qy71pmqxBUdijHpl2mPfdFxmlSVsBaMeHsU8tf3VYm4DqJEAm4gTG7r1Q7t4n65W0O+f+uI/qOmZu6vQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 30 Aug 2023 07:56:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ2oYKABgzDtwGqkuLqOQEWgZPabACco4AgAAHSoA=
- Thread-topic: [PATCH v2 1/2] xen: add stubs dir to include path
Hi Jan,
> On 30 Aug 2023, at 09:30, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 29.08.2023 16:34, Oleksii Kurochko wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -438,6 +438,7 @@ ifdef building_out_of_srctree
>> endif
>> CFLAGS += -I$(srctree)/include
>> CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include
>> +CFLAGS += -I$(srctree)/include/stubs
>>
>> # Note that link order matters!
>> ALL_OBJS-y := common/built_in.o
>
> I have to admit that I'm not entirely happy with the name. I wonder what
> other REST maintainers think. In particular I would consider using
> Linux'es "asm-generic" name instead, allowing to cover both stub headers
> like the one to be introduced here, but also other kinds of "fallback"
> ones.
>
This is a great idea.
+1 on asm-generic
Cheers
Bertrand
> Jan
>
|
