Re: [PATCH v2 1/2] xen: add stubs dir to include path

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-08-30 at 09:30 +0200, Jan Beulich wrote:
> On 29.08.2023 16:34, Oleksii Kurochko wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -438,6 +438,7 @@ ifdef building_out_of_srctree
> >  endif
> >  CFLAGS += -I$(srctree)/include
> >  CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include
> > +CFLAGS += -I$(srctree)/include/stubs
> >  
> >  # Note that link order matters!
> >  ALL_OBJS-y                := common/built_in.o
> 
> I have to admit that I'm not entirely happy with the name. I wonder
> what
> other REST maintainers think. In particular I would consider using
> Linux'es "asm-generic" name instead, allowing to cover both stub
> headers
> like the one to be introduced here, but also other kinds of
> "fallback"
> ones.
It make sense. I'll update the patch series.


~ Oleksii