[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 4 Sep 2023 10:09:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BPV1n5wU+6knr2XSodVZzlJ7DcWx89sqS/gXBWrYl7g=; b=ZzNtxf+NhoVRHk9Y8WX1HLWmDKVOc/e8zQSp+nIGFa/yblLou/2YuhvzJW3sfNDw/gdgq7dB59qoEy0s7/P+66PA8aGloA3/whcOybRKlJnT2rZEZagm0IY116rydL43y5N+UhqaZHuujOkDzIMtGjak5YP4888oKRqBQZQDeB+usqdxgJ7w3MxoIzBJn7dG8eyTBwqqCfAoAbB30nJnF0UpgchKkBIteBtg7TFilAFo/E188Pew6I0dw/ikis449K3LmvCcYis83HX5/JOSPEJ9LY3giVh2k+p1fhVOf+GU0tNzkQk0pG6flnhzsxa+0oTNvrQTpvnTVrlBxlO3Fg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThPuebcTIf67xv83p8adNHBv47AV6gF9rVQBHdcfCXIKgRM/2jXAQ2NZNvlxuZkXNJcT4dus4LKD9thcrPe8Lbjyr+bFJitH2mJNXZ7RorBRXpAWd9cG88G5oE/OUm/TX+9FtYivJTlHti+JouoPdxee70Z9PUUqMQM8m1qSvLrwmUwWAw7+iO1izbGqj0QCGGzq8SSihxBzWnoZRlre5T2oe6niyWeaWKRavZbA/5KZ4tFctnLYi8Bsl/UyZJPmOaIj0TcH7OBk2Ts0O516G5VFpBxriTBrtdRDR6WFiJb9ItDTnTxMzoPjHXz3ETnhzrJaUhJ0vvAsCfSzvaXzRQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 04 Sep 2023 08:10:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.09.2023 09:19, Nicola Vetrini wrote:
> On 04/09/2023 09:02, Jan Beulich wrote:
>> Further in the cover letter you say "Deviating variables needs more
>> care, and
>> is therefore postponed to another patch", yet then here you annotate a
>> couple
>> of variables as well. Could you clarify what the criteria are for
>> "needs more
>> care"?
>
> I see. I did not intend for those changes to end up in this patch,
> although those two are
> clearly only used by asm code and therefore are excepted.
> Most of the variables I left out are also used by C code, therefore they
> may be eligible for
> a declaration, but where to put this declaration requires a careful
> examination in my opinion.
> They are not too many, tough.
Anything also used by C code (and not in the same CU) clearly wants a
declaration.
Jan
|
