Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 04/09/2023 10:09, Jan Beulich wrote:
> On 04.09.2023 09:19, Nicola Vetrini wrote:
> > On 04/09/2023 09:02, Jan Beulich wrote:
> > > Further in the cover letter you say "Deviating variables needs more
> > > care, and
> > > is therefore postponed to another patch", yet then here you annotate 
> > > a
> > > couple
> > > of variables as well. Could you clarify what the criteria are for
> > > "needs more
> > > care"?
> > I see. I did not intend for those changes to end up in this patch,
> > although those two are
> > clearly only used by asm code and therefore are excepted.
> > Most of the variables I left out are also used by C code, therefore 
> > they
> > may be eligible for
> > a declaration, but where to put this declaration requires a careful
> > examination in my opinion.
> > They are not too many, tough.
> Anything also used by C code (and not in the same CU) clearly wants a
> declaration.
>
> Jan
I think that a declaration (in an header) is a good idea also when a 
symbol is defined in a translation unit
and it used both by C code in that TU and asm modules. This also allows 
C code that uses
that symbol to be moved around freely without other changes.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)