Re: [PATCH v4 1/2] xen: asm-generic support

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-09-06 at 16:06 +0100, Anthony PERARD wrote:
> On Wed, Sep 06, 2023 at 02:40:29PM +0200, Jan Beulich wrote:
> > On 06.09.2023 14:28, Oleksii wrote:
> > > On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote:
> > > > You've removed quite a bit of functionality, comparing with the
> > > > Linux
> > > > original. May I ask why that is? What they have all makes sense
> > > > to
> > > > me,
> > > > and looks to be useful down the road.
> > > I decided to take only minimum needed now but if you think it
> > > would be
> > > better to use the latest Linux's Makefile.asm-generic then I will
> > > update it in the next patch version.
> > 
> > Unless there are things getting in the way, I indeed think it would
> > be
> > better to take the whole thing largely verbatim (a few edits are
> > unavoidable afaict).
> 
> Yes, I think it would be useful as well to take most of the file from
> Linux. At least, this would include the "$(unwanted)" variable, which
> is
> used to remove old wrapper when an header is removed from "generic-
> y".
> But instead of the "-include $(kbuild-file)", could you include
> "$(src)/Makefile" instead like we do in "Rules.mk"? We don't have
> $(kbuild-file) macro anyway, and I don't see the point in using files
> name "Kbuild" when "Makefile" works and is enough.
> 
Thank you for your feedback.

I'll take into account your suggestions in the next patch version.

~ Oleksii