[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/x2apic: remove usage of ACPI_FADT_APIC_CLUSTER
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Tue, 24 Oct 2023 12:26:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBSxkr80y2D7Yl0jWPOGJABCEKQmi+24UWVd2iKXgGQ=; b=STHFdAuDW+ZFYM3GBVmRdHfKFm1JjrrqHyLmCcMxbTHVhiWwxEs/9YEVm+OlR9I6ns6YbJSeJDZzMqCHpmKNI7S00uToT721NNRLWkqwfQW8It6eJlIOaWwsJ+ssyEnw3Pl6Mvdke+SEvIUIo2wH8nvUvBLRvTo+vmPyaAPiFHRzRuIQtpWWJqrutfEUHaKRXVCviZx95MFetVq2s22QOt1pTX/t6K6W6ZJVNo4854hkZqKbOmWeLbVJqKyKSpKdN+59/yA6rzEDagiHC0po+VaZdhTihwgZuOEWrVNa5N7tUa7+1GQbSGc7A+lLJWF08ZOYDG4ztS8dfqobBcql0A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GbILVGEykJVEUvI8tQvUwYctXfdNzjwQaSMr/9Xad6lcnrTQmAmwuFC5aN8SSchEbNvhuPvPdivs0gUETT9xMPaHOXjKHue8DHtH5yOhjkLhOvTAW2zldcmFdEXdnsgzV/UGcrQtQan9QsSsz2PXLiYcU8BNb5rJuM38hN/l1aSx8TmponCaA2NN/x2E6NAmO9+k8SHYysQphSUeHmYVARp4SSS3VvkDsOslCz2QBk/xwO708lhal15q2qDKC51vjH6ggxKqF0/cc9SAZIGJPr5SlOF6jtYoLT9r7Fvbyc93dScT+Fh4XlrDF/NV6NdK7dNVkCnh90UiiX1z4ddVHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 24 Oct 2023 10:26:54 +0000
- Ironport-data: A9a23:7gIX2KzdnZvHDWFVmKd6t+cQxyrEfRIJ4+MujC+fZmUNrF6WrkUFx 2AXXj3QMqyJNmfweNl+OYu+oEwGuJHTmNRrHQE/+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjPzOHvykTrecZkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EgHUMja4mtC5QVmP6wT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUVy0 aREJXNdVx2G2POywOulTek9i/12eaEHPKtH0p1h5RfwKK58BKvlGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVkFUZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r13LKXw3KgCd16+LuQxvR1nUWChXEvKjIsSGGJs8in1xThVIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxLZcEitcQ2bSc3z VLPlNTsbRRwtJWFRHTb8a2bxQ5eIgAQJG4GIDQCFA0M5oG5pJlp1k6WCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs=
- Ironport-hdrordr: A9a23:lwjUKq0ZIA6s3r5PUdraCAqjBTNyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHO1OkPMs1NaZLULbUQ6TQL2KgrGSpAEIdxeeygcZ79 YZT0EcMqy7MbEZt7ed3ODQKb9Jr7e6GeKT9J7jJhxWPGNXgtRbnmNE43GgYyhLrWd9ZaYRJd 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njDsRqYrJrBVzSI1BYXVD1ChZ0493 LergD/7qK/99mm1x7n0XPJ5Zg+oqqv9jIDPr3DtiEmEESttu+aXvUjZ1REhkF2nAib0idqrD ALmWZkAy080QKUQoj/m2qR5+Cp6kdT15al8y7UvZKrm72GeNo3ZvAx+r5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa4HZcjEBS5dL7tUYvJrc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFkgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCPefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve4PcV T6ISFlXEIJCjHT4Je1rex2Gzj2MRWAYQg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The ACPI FADT APIC_CLUSTER flag mandates that when the interrupt delivery is
Logical mode APIC must be configured for Cluster destination model. However in
apic_x2apic_probe() such flag is incorrectly used to gate whether Physical mode
can be used.
Since Xen when in x2APIC mode only uses Logical mode together with Cluster
model completely remove checking for ACPI_FADT_APIC_CLUSTER, as Xen always
fulfills the requirement signaled by the flag.
Fixes: eb40ae41b658 ('x86/Kconfig: add option for default x2APIC destination
mode')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/arch/x86/genapic/x2apic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c
index ca1db27157e2..707deef98c27 100644
--- a/xen/arch/x86/genapic/x2apic.c
+++ b/xen/arch/x86/genapic/x2apic.c
@@ -231,8 +231,7 @@ const struct genapic *__init apic_x2apic_probe(void)
*/
x2apic_phys = iommu_intremap != iommu_intremap_full ||
(acpi_gbl_FADT.flags & ACPI_FADT_APIC_PHYSICAL) ||
- (IS_ENABLED(CONFIG_X2APIC_PHYSICAL) &&
- !(acpi_gbl_FADT.flags & ACPI_FADT_APIC_CLUSTER));
+ IS_ENABLED(CONFIG_X2APIC_PHYSICAL);
}
else if ( !x2apic_phys )
switch ( iommu_intremap )
--
2.42.0
|
