[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/x2apic: remove usage of ACPI_FADT_APIC_CLUSTER


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 30 Oct 2023 15:12:01 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=26FFgfDy+XeQ9w/5g7cx/xYQJAeK+xLT3MfRJCPlin0=; b=JLlbnVuVOQGU0sghhpYfpKZW2/UL4Da54ZAALxxbSKQ8VCesJE6mcq0n0oyVguEk+ot4iZDDMZeAVcNkEWyv2c1CirhZVFSBXXCp9vDkpKW0yVwdn2TE769oug/SlddgGzpRwLdSmEdosf3p888rEmFW7EHWTK1rOdYxtyswZnNPiwEgaFopniC/a/yG7+Y5aPRdRusCEPQH8vPGJr2lY5UV1khDRWK3X+gFF9e319JHc3pKg37HgaiP37y60Y4iHl2b4CSlY96XDPR1uFvpFzWpf7zmQPDwxQfQHS59Ez/owA2dkVmlwV9o6c02fiuVBytBBZ0nVylCVbq89Zn9YA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCcmqJMIDm4L6witGpNfqFxH9ZlCAv7SE02jf5zjeC7lhHiVAzr4VZ5HKoJA0uOI4miTJwnGCsPtnml2AES1iKMOSvrRGz5Lpct5bYYRdyQQDGT5oscNYCvtg+YtUxJtN5bvd5XWPnz3cgQModHFWl4IZmSJSrZSBAKFxRr60SxvEmLje7NqJzXzMKumgtanJ8MbvZdtCvLeuGeLzPfqlTsbHeCigbzPiJHhx27NFxPASSpb7A/AfnlnuSCrDR339oRiP+3dx01kfeGXgT8bS4Xx33VEZu83dvjCYtrvE+JkMrtK8Mv6+U8lgBYIF754sropr+5cohBnb/fs95fveA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 30 Oct 2023 14:12:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.10.2023 12:26, Roger Pau Monne wrote:
> The ACPI FADT APIC_CLUSTER flag mandates that when the interrupt delivery is
> Logical mode APIC must be configured for Cluster destination model.  However 
> in
> apic_x2apic_probe() such flag is incorrectly used to gate whether Physical 
> mode
> can be used.
> 
> Since Xen when in x2APIC mode only uses Logical mode together with Cluster
> model completely remove checking for ACPI_FADT_APIC_CLUSTER, as Xen always
> fulfills the requirement signaled by the flag.
> 
> Fixes: eb40ae41b658 ('x86/Kconfig: add option for default x2APIC destination 
> mode')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.