[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/x2apic: remove usage of ACPI_FADT_APIC_CLUSTER
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 30 Oct 2023 15:13:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozhRjkKQPTvu5sO3J9PWmPQFmjbIELeiheWHXP7CP6c=; b=hWYvL7EJOJEK4fMoHy0/FJxfMA4LSCESOIJARTeNGte22FRbhcEN3IXBPQZEkPXlqaRYixL8RrFfaXi6Y+ER74Wm+xY/slWuwzA0zk+qmXufpbmwM6lh34K/SdnB0KiJP2SCVvdQSp7n9jp12DmeZN2wwNjgjX0H02XgQO7StAVx8EiyUV771cm6GNeb9x26LMEBOKGoKOKWXKBqCDpYElBAZeGUu9QeRHkhlATBj7iOZd4MTur3EYv7RczQ6erj6r79NGnWPmOzn7fMjiu8jLPuSonC5oqZxwqJVyHt1Vt/eA+X8lHimgih0JbZ6R6Q5AYJS/iY+Ua9o5+mqlPsOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kNgzw+ID/Fh/6ndnlmqz0+y0w+epN7ZWtS6NKa9TWYkDXOJPouqeHYiLsmRogz98DyVQQ/d5u4NqPZZzR7Bfy9X4T6jRXocV6ZFSTxT7EsbBTkvjx6/+u1f2kiWBjtVJ5l6CTbQBazPm83YcViQo27pVLMk1zvB6J9bHHBOm29l6+l6QR9dq5XVNYjAJ37RDPj9hmIoiHVN8LZeBTddg9Gu+ufxR3Aty4RQGBFU8yIRx1CAZNX9bx9Yx0Xeb+w6HsKvxlXF9QhDE2pjtBqktencdBEuc4offgbipO2oHA0yeJx47vrK0tIkksKmAFSunUacSHORa5OK5xCnpkhnD0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 30 Oct 2023 14:13:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.10.2023 12:26, Roger Pau Monne wrote:
> The ACPI FADT APIC_CLUSTER flag mandates that when the interrupt delivery is
> Logical mode APIC must be configured for Cluster destination model. However
> in
> apic_x2apic_probe() such flag is incorrectly used to gate whether Physical
> mode
> can be used.
>
> Since Xen when in x2APIC mode only uses Logical mode together with Cluster
> model completely remove checking for ACPI_FADT_APIC_CLUSTER, as Xen always
> fulfills the requirement signaled by the flag.
Actually, one remark: The text in the 6.5 spec really only mentions xAPIC
mode, so it's not entirely clear whether the two flags actually have any
meaning for x2APIC mode.
Jan
|
