[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/x2apic: remove usage of ACPI_FADT_APIC_CLUSTER
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 30 Oct 2023 17:32:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XoRRgVAMe+aAXAGhmW4wc+Zar4xu+5zNZP0iuqZ2Zto=; b=GcNBZyNb7jQ/yr8l17bgx31JrIl7EAtlzZeKnqMn0xT3loWjYlTFGjG/z664Gqp0pGwIztYW4UlDGshDV3o+OTpdugYrpZudOugBMOX7ZKJumzGhjxB3fbhhbXgnGyejVgTScdsgnzZNpLhw/DZaK3ThryZyhtZt3vlKMSwH1jWvqw8Q4JwWQDfdtAEwV5Lz0bw+bmsIHyPhV2TRwQkdfHkMhc1foi/o4ZNdE8T20Jc+16/x9F92+iPjnK31vCzZcEGuTAZld+mtxl1c9SHA8Nyh2mECrHhD7AipQ3Z1f5mVk4k9G94TJHUtQ4v1fEbrJi5CIXXFA3ppMyof2d0UFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TkAPsClAeUr9h9H8atMv5DMawEXA6H47L+jy4X7J4J2OpB/G248zzvghYWvcPC7tNsiazkZVfXXawPw6Cv/Pc5z7VecVMBUjtxLRqvheMFdfc88dtBBCVrPivHk9BLwFfdYok0MZNq+FJJVjbqiO1sd1S903Ga+JCOpqRSQJfF5LQyTpcmUbCso1rSTO2i3qnnAhmYke0l0Qa0U92roiyOzM5d+3NtG3vkI8ai4QQra3ElwY4ePrbwY7Om5CiKPEMzo4XEX+0yNgxvgIfAiJwSSGZ5llfO1YvPQLURsMXUDfq5m/WNI/4dnabqH/0oEmilNrJsO7tUnLVCqOnGBZog==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 30 Oct 2023 16:32:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.10.2023 17:19, Roger Pau Monné wrote:
> On Mon, Oct 30, 2023 at 03:13:50PM +0100, Jan Beulich wrote:
>> On 24.10.2023 12:26, Roger Pau Monne wrote:
>>> The ACPI FADT APIC_CLUSTER flag mandates that when the interrupt delivery is
>>> Logical mode APIC must be configured for Cluster destination model.
>>> However in
>>> apic_x2apic_probe() such flag is incorrectly used to gate whether Physical
>>> mode
>>> can be used.
>>>
>>> Since Xen when in x2APIC mode only uses Logical mode together with Cluster
>>> model completely remove checking for ACPI_FADT_APIC_CLUSTER, as Xen always
>>> fulfills the requirement signaled by the flag.
>>
>> Actually, one remark: The text in the 6.5 spec really only mentions xAPIC
>> mode, so it's not entirely clear whether the two flags actually have any
>> meaning for x2APIC mode.
>
> Hm, indeed. That wants to be in a different fix however.
If any at all - it wouldn't be the first time that when adding x2APIC, editing
certain places simply didn't happen. If anything needs changing here, of course
I agree that the further adjustment would want to be a separate change.
Jan
|
